Skip to content

Add add_all_reviewers boolean input #577

@mvlassis

Description

@mvlassis

Is your feature request related to a problem? Please describe.
We are looking into incorporating this action in our team, and we want to automatically assign all reviewers of the original PRs on the backports. Unfortunately, the add_requested_reviewers option is not super useful in our case, since the requested reviewers have probably already reviewed (and approved), and thus do not show up when add_requested_reviewers is set to true.

Describe the solution you'd like
I think we can make use of the listReviews function and try to create a set of all people who have already reviewed. Upstream documentation on the function can be found here.

Describe alternatives you've considered
This input is supposed to be a superset with add_requested_reviewers since this is supposed to be a superset (requested + people who have already reviewed). There shouldn't be an issue if both inputs are set to true, but perhaps it could make sense to merge them into a add_reviewers input or similar, with non-boolean accepted values.

Additional context
There already is a similar issue at #2, but I'm not sure whether it refers to the exact same thing. #4 is supposed to close that issue (according to the PR description), but the issue is still open.

I can work on the implementation if it is deemed that the option makes sense :)

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions