Skip to content

Commit 6461c8e

Browse files
committed
Rename test for single partition join to clarify that repartitioning is required
1 parent ef7d6da commit 6461c8e

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

datafusion/core/tests/physical_optimizer/enforce_distribution.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3747,7 +3747,7 @@ fn distribution_satisfaction_superset_hash_matches_sanity_check() -> Result<()>
37473747
}
37483748

37493749
#[test]
3750-
fn single_partition_join_skips_repartition() -> Result<()> {
3750+
fn single_partition_join_requires_repartition() -> Result<()> {
37513751
let left = parquet_exec();
37523752
let right = parquet_exec();
37533753
let join_on = vec![(

datafusion/physical-optimizer/src/enforce_distribution.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1314,7 +1314,6 @@ pub fn ensure_distribution(
13141314
child = add_merge_on_top(child);
13151315
}
13161316
Distribution::HashPartitioned(_) => {
1317-
// See https://github.com/apache/datafusion/issues/18341#issuecomment-3503238325 for background
13181317
let satisfaction = distribution_satisfaction(
13191318
&child.plan,
13201319
&requirement,

0 commit comments

Comments
 (0)