fix clippy

kosiew · kosiew · commit 6d01e88dc78d · 2026-01-16T16:14:53.000+08:00
diff --git a/datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs b/datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs
@@ -658,10 +658,9 @@ impl ConstEvaluator {
                     // when evaluating 0-row struct literals
                     if let Expr::Literal(ScalarValue::Struct(struct_array), _) =
                         expr.as_ref()
+                        && struct_array.len() == 0
                     {
-                        if struct_array.len() == 0 {
-                            return false;
-                        }
+                        return false;
                     }
                 }
                 true

Original file line number	Diff line number	Diff line change
`@@ -658,10 +658,9 @@ impl ConstEvaluator {`
`658`	`658`	`// when evaluating 0-row struct literals`
`659`	`659`	`if let Expr::Literal(ScalarValue::Struct(struct_array), _) =`
`660`	`660`	`expr.as_ref()`
	`661`	`+ && struct_array.len() == 0`
`661`	`662`	`{`
`662`		`- if struct_array.len() == 0 {`
`663`		`- return false;`
`664`		`- }`
	`663`	`+ return false;`
`665`	`664`	`}`
`666`	`665`	`}`
`667`	`666`	`true`