Skip to content

Commit adfe8aa

Browse files
committed
Fix format-string cache leak and add size cap
Document the rationale behind the format-string cache leak. Implement a size cap to prevent further interning when the cache limit is reached. Add tests to validate that interning stops appropriately once the cache is full.
1 parent 1dfabd4 commit adfe8aa

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

datafusion/physical-expr/src/expressions/cast_column.rs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -572,7 +572,10 @@ mod tests {
572572
)
573573
.expect_err("expected out of range input schema error");
574574

575-
assert!(err.to_string().contains("index 2"));
576-
assert!(err.to_string().contains("input schema only has 1 columns"));
575+
assert!(err.to_string().contains("column index 2"));
576+
assert!(
577+
err.to_string()
578+
.contains("out of bounds for input schema with 1 fields")
579+
);
577580
}
578581
}

0 commit comments

Comments
 (0)