Mark require-provenance flag as depricated server/#3431 (#572)

* Mark require-provenance flag as depricated server/#3431

* Added check of return value of MarkDepricated

Author: ToreMerkely

cmd/kosli/createEnvironment.go

@@ -24,11 +24,7 @@ The following types are supported:
   - server     - Generic type
   - logical    - Logical grouping of real environments
 
-By default, the environment does not require artifacts provenance (i.e. environment snapshots will not 
-become non-compliant because of artifacts that do not have provenance). You can require provenance for all artifacts
-by setting --require-provenance=true
-
-Also, by default, kosli will not make new snapshots for scaling events (change in number of instances running).
+By default, kosli will not make new snapshots for scaling events (change in number of instances running).
 For large clusters the scaling events will often outnumber the actual change of SW.
 
 It is possible to enable new snapshots for scaling events with the --include-scaling flag, or turn
@@ -106,9 +102,14 @@ func newCreateEnvironmentCmd(out io.Writer) *cobra.Command {
 	cmd.Flags().BoolVar(&o.payload.RequireProvenance, "require-provenance", false, requireProvenanceFlag)
 	cmd.Flags().StringSliceVar(&o.payload.IncludedEnvironments, "included-environments", []string{}, includedEnvironments)
 
+	err := cmd.Flags().MarkDeprecated("require-provenance", "this flag is deprecated and will be removed in a future version. Use policies instead.")
+	if err != nil {
+		logger.Error("failed to mark require-provenance as deprecated: %v", err)
+	}
+
 	addDryRunFlag(cmd)
 
-	err := RequireFlags(cmd, []string{"type"})
+	err = RequireFlags(cmd, []string{"type"})
 	if err != nil {
 		logger.Error("failed to configure required flags: %v", err)
 	}

cmd/kosli/createEnvironment_test.go

@@ -51,14 +51,14 @@ func (suite *CreateEnvironmentCommandTestSuite) TestCreateEnvironmentCmd() {
 			golden:    "environment newEnv1 was created\n",
 		},
 		{
-			name:   "can create K8S env with --require-provenance",
-			cmd:    "create env strictEnv --type K8S --require-provenance" + suite.defaultKosliArguments,
-			golden: "environment strictEnv was created\n",
+			name:        "can create K8S env with --require-provenance",
+			cmd:         "create env strictEnv --type K8S --require-provenance" + suite.defaultKosliArguments,
+			goldenRegex: "Flag --require-provenance has been deprecated.*\nenvironment strictEnv was created",
 		},
 		{
-			name:   "can create K8S env with --require-provenance=false",
-			cmd:    "create env relaxedEnv --type K8S --require-provenance=false" + suite.defaultKosliArguments,
-			golden: "environment relaxedEnv was created\n",
+			name:        "can create K8S env with --require-provenance=false",
+			cmd:         "create env relaxedEnv --type K8S --require-provenance=false" + suite.defaultKosliArguments,
+			goldenRegex: "Flag --require-provenance has been deprecated.*\nenvironment relaxedEnv was created",
 		},
 		{
 			wantError: true,