macOS: focusing of minimized window broken

kovidgoyal · kovidgoyal · commit 21fa5bb1ce23 · 2025-08-23T07:49:06.000+05:30
This was done to fix #8913 in d7c2cdc. Explicitly de-miniaturize before making key.
diff --git a/glfw/cocoa_window.m b/glfw/cocoa_window.m
@@ -2291,8 +2291,13 @@ int _glfwPlatformWindowBell(_GLFWwindow* window UNUSED)
 
 void _glfwPlatformFocusWindow(_GLFWwindow* window)
 {
-    // Make us the active application
+    if (_glfwPlatformWindowIconified(window)) {
+        // miniaturized windows return false in canBecomeKeyWindow therefore
+        // unminiaturize first
+        [window->ns.object deminiaturize:nil];
+    }
     if ([window->ns.object canBecomeKeyWindow]) {
+        // Make us the active application
         [NSApp activateIgnoringOtherApps:YES];
         [window->ns.object makeKeyAndOrderFront:nil];
     }

Original file line number	Diff line number	Diff line change
`@@ -2291,8 +2291,13 @@ int _glfwPlatformWindowBell(_GLFWwindow* window UNUSED)`
`2291`	`2291`
`2292`	`2292`	`void _glfwPlatformFocusWindow(_GLFWwindow* window)`
`2293`	`2293`	`{`
`2294`		`- // Make us the active application`
	`2294`	`+ if (_glfwPlatformWindowIconified(window)) {`
	`2295`	`+ // miniaturized windows return false in canBecomeKeyWindow therefore`
	`2296`	`+ // unminiaturize first`
	`2297`	`+ [window->ns.object deminiaturize:nil];`
	`2298`	`+ }`
`2295`	`2299`	`if ([window->ns.object canBecomeKeyWindow]) {`
	`2300`	`+ // Make us the active application`
`2296`	`2301`	`[NSApp activateIgnoringOtherApps:YES];`
`2297`	`2302`	`[window->ns.object makeKeyAndOrderFront:nil];`
`2298`	`2303`	`}`