Log warnings from libpng when debug rendering is on

kovidgoyal · kovidgoyal · commit 31191fd48cea · 2020-08-12T06:21:14.000+05:30
diff --git a/kitty/png-reader.c b/kitty/png-reader.c
@@ -6,6 +6,7 @@
  */
 
 #include "png-reader.h"
+#include "state.h"
 
 
 struct fake_file { const uint8_t *buf; size_t sz, cur; };
@@ -35,8 +36,8 @@ read_png_error_handler(png_structp png_ptr, png_const_charp msg) {
 }
 
 static void
-read_png_warn_handler(png_structp UNUSED png_ptr, png_const_charp UNUSED msg) {
-    // ignore warnings
+read_png_warn_handler(png_structp UNUSED png_ptr, png_const_charp msg) {
+    if (global_state.debug_rendering) log_error("libpng WARNING: %s", msg);
 }
 
 #define ABRT(code, msg) { if(d->err_handler) d->err_handler(#code, msg); goto err; }

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@`
`6`	`6`	`*/`
`7`	`7`
`8`	`8`	`#include "png-reader.h"`
	`9`	`+#include "state.h"`
`9`	`10`
`10`	`11`
`11`	`12`	`struct fake_file { const uint8_t *buf; size_t sz, cur; };`
`@@ -35,8 +36,8 @@ read_png_error_handler(png_structp png_ptr, png_const_charp msg) {`
`35`	`36`	`}`
`36`	`37`
`37`	`38`	`static void`
`38`		`-read_png_warn_handler(png_structp UNUSED png_ptr, png_const_charp UNUSED msg) {`
`39`		`- // ignore warnings`
	`39`	`+read_png_warn_handler(png_structp UNUSED png_ptr, png_const_charp msg) {`
	`40`	`+ if (global_state.debug_rendering) log_error("libpng WARNING: %s", msg);`
`40`	`41`	`}`
`41`	`42`
`42`	`43`	`#define ABRT(code, msg) { if(d->err_handler) d->err_handler(#code, msg); goto err; }`