Merge branch 'add-cursor-trail-color-option' of https://github.com/CollinEMac/kitty

Author: kovidgoyal

kitty/options/definition.py

@@ -416,6 +416,18 @@
 '''
     )
 
+opt('cursor_trail_color', 'none',
+    option_type='to_color_or_none',
+    ctype='!cursor_trail_color',
+    long_text='''
+Set the color of the cursor trail when :opt:`cursor_trail` is enabled.
+If set to 'none' (the default), the cursor trail will use the cursor's
+background color. Otherwise, specify a color value (e.g., #ff0000 for red,
+or a named color like 'red'). This allows you to customize the appearance
+of the cursor trail independently of the cursor color.
+'''
+)
+
 egr()  # }}}
 
 # scrollback {{{

kitty/options/parse.py

@@ -215,6 +215,11 @@ cursor_trail_decay(PyObject *src, Options *opts) {
     opts->cursor_trail_decay_slow = PyFloat_AsFloat(PyTuple_GET_ITEM(src, 1));
 }
 
+static inline void
+cursor_trail_color(PyObject *src, Options *opts) {
+    opts->cursor_trail_color = color_or_none_as_int(src);
+}
+
 static void
 parse_font_mod_size(PyObject *val, float *sz, AdjustmentUnit *unit) {
     PyObject *mv = PyObject_GetAttrString(val, "mod_value");

kitty/options/to-c-generated.h

@@ -576,7 +576,6 @@ def cursor_trail_decay(x: str) -> tuple[float, float]:
     slow = max(slow, fast)
     return fast, slow
 
-
 def scrollback_lines(x: str) -> int:
     ans = int(x)
     if ans < 0:

kitty/options/to-c.h

@@ -1252,7 +1252,12 @@ draw_cursor_trail(CursorTrail *trail, Window *active_window) {
     glUniform2fv(trail_program_layout.uniforms.cursor_edge_x, 1, trail->cursor_edge_x);
     glUniform2fv(trail_program_layout.uniforms.cursor_edge_y, 1, trail->cursor_edge_y);
 
-    color_vec3(trail_program_layout.uniforms.trail_color, active_window ? active_window->render_data.screen->last_rendered.cursor_bg : OPT(foreground));
+    color_type trail_color = OPT(cursor_trail_color);
+    if (trail_color == 0) {  // 0 means "none" was specified
+        trail_color = active_window ? active_window->render_data.screen->last_rendered.cursor_bg : OPT(foreground);
+    }
+    color_vec3(trail_program_layout.uniforms.trail_color, trail_color);
+
     glUniform1fv(trail_program_layout.uniforms.trail_opacity, 1, &trail->opacity);
 
     glDrawArrays(GL_TRIANGLE_FAN, 0, 4);

kitty/options/types.py

@@ -54,6 +54,7 @@ typedef struct {
     monotonic_t cursor_trail;
     float cursor_trail_decay_fast;
     float cursor_trail_decay_slow;
+    color_type cursor_trail_color;
     float cursor_trail_start_threshold;
     unsigned int url_style;
     unsigned int scrollback_pager_history_size;