Close fds explicitly

kovidgoyal · kovidgoyal · commit 6131f4cba79a · 2024-09-28T12:40:42.000+05:30
diff --git a/kitty/child.c b/kitty/child.c
@@ -136,7 +136,10 @@ spawn(PyObject *self UNUSED, PyObject *args) {
                 int fd = PyLong_AsLong(pfd);
                 if (fd > -1) {
                     if (fd == min_closed_fd) min_closed_fd++;
-                    else if (safe_dup2(fd, min_closed_fd++) == -1) exit_on_err("dup2() failed for forwarded fd 1");
+                    else {
+                        if (safe_dup2(fd, min_closed_fd++) == -1) exit_on_err("dup2() failed for forwarded fd 1");
+                        safe_close(fd, __FILE__, __LINE__);
+                    }
                 }
             }
             if (forward_stdio) {

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,10 @@ spawn(PyObject self UNUSED, PyObject args) {`
`136`	`136`	`int fd = PyLong_AsLong(pfd);`
`137`	`137`	`if (fd > -1) {`
`138`	`138`	`if (fd == min_closed_fd) min_closed_fd++;`
`139`		`- else if (safe_dup2(fd, min_closed_fd++) == -1) exit_on_err("dup2() failed for forwarded fd 1");`
	`139`	`+ else {`
	`140`	`+ if (safe_dup2(fd, min_closed_fd++) == -1) exit_on_err("dup2() failed for forwarded fd 1");`
	`141`	`+ safe_close(fd, __FILE__, __LINE__);`
	`142`	`+ }`
`140`	`143`	`}`
`141`	`144`	`}`
`142`	`145`	`if (forward_stdio) {`