Add support for the underscore key found in some keyboard layouts

Fixes #1639

Author: kovidgoyal

docs/changelog.rst

@@ -4,6 +4,13 @@ Changelog
 |kitty| is a feature full, cross-platform, *fast*, GPU based terminal emulator.
 To update |kitty|, :doc:`follow the instructions <binary>`.
 
+0.14.1 [future]
+---------------------
+
+- Add support for the underscore key found in some keyboard layouts
+  (:iss:`1639`)
+
+
 0.14.0 [2019-05-24]
 ---------------------
 

glfw/cocoa_window.m

@@ -272,6 +272,7 @@ static int translateKey(unsigned int key, GLFWbool apply_keymap)
                 K('[', LEFT_BRACKET);
                 K(']', RIGHT_BRACKET);
                 K('+', PLUS);
+                K('_', UNDERSCORE);
                 K('`', GRAVE_ACCENT);
                 K('\\', BACKSLASH);
 #undef K
@@ -2234,6 +2235,7 @@ GLFWAPI void glfwGetCocoaKeyEquivalent(int glfw_key, int glfw_mods, unsigned sho
         K('[', LEFT_BRACKET);
         K(']', RIGHT_BRACKET);
         K('+', PLUS);
+        K('_', UNDERSCORE);
         K('`', GRAVE_ACCENT);
         K('\\', BACKSLASH);
 

glfw/glfw3.h

@@ -410,6 +410,7 @@ extern "C" {
 #define GLFW_KEY_WORLD_1            161 /* non-US #1 */
 #define GLFW_KEY_WORLD_2            162 /* non-US #2 */
 #define GLFW_KEY_PLUS               163
+#define GLFW_KEY_UNDERSCORE         164
 
 /* Function keys */
 #define GLFW_KEY_ESCAPE             256

glfw/input.c

@@ -488,6 +488,7 @@ const char* _glfwGetKeyName(int key)
         case GLFW_KEY_WORLD_1:      return "WORLD 1";
         case GLFW_KEY_WORLD_2:      return "WORLD 2";
         case GLFW_KEY_PLUS:         return "PLUS";
+        case GLFW_KEY_UNDERSCORE:   return "UNDERSCORE";
 
         // Function keys
         case GLFW_KEY_ESCAPE:       return "ESCAPE";

glfw/xkb_glfw.c

@@ -47,6 +47,7 @@
         S(backslash, BACKSLASH); \
         S(bracketright, RIGHT_BRACKET); \
         S(plus, PLUS); \
+        S(underscore, UNDERSCORE); \
         S(grave, GRAVE_ACCENT); \
         S(Escape, ESCAPE); \
         S(Return, ENTER); \

kitty/config.py

@@ -24,6 +24,7 @@
     "'": 'APOSTROPHE',
     ',': 'COMMA',
     '-': 'MINUS',
+    '_': 'UNDERSCORE',
     '.': 'PERIOD',
     '/': 'SLASH',
     ';': 'SEMICOLON',

kitty/glfw-wrapper.h

@@ -1196,6 +1196,7 @@ init_glfw(PyObject *m) {
     ADDC(GLFW_KEY_WORLD_1);
     ADDC(GLFW_KEY_WORLD_2);
     ADDC(GLFW_KEY_PLUS);
+    ADDC(GLFW_KEY_UNDERSCORE);
 
 // --- Function keys -----------------------------------------------------------
     ADDC(GLFW_KEY_ESCAPE);