Fix recursion error, fix duplicate argument

Author: sternakt

fastapi_code_generator/parser.py

@@ -347,7 +347,22 @@ def get_argument_list(self, snake_case: bool, path: List[str]) -> List[Argument]
                 or argument.type_hint.startswith('Optional[')
             )
 
-        return arguments
+        # Group argument with same name into one argument.name argument.type_hint into Argument(name = argument.name, type_hint = "Union[argument.type_hint, argument.type_hint]")
+        grouped_arguments: DefaultDict[str, List[Argument]] = DefaultDict(list)
+        sorted_arguments = []
+        for argument in arguments:
+            grouped_arguments[argument.name].append(argument)
+        for argument_list in grouped_arguments.values():
+            if len(argument_list) == 1:
+                sorted_arguments.append(argument_list[0])
+            else:
+                argument = argument_list[0]
+                type_hints = [arg.type_hint for arg in argument_list]
+                argument.type_hint = UsefulStr(f"Union[{', '.join(type_hints)}]")
+                self.imports_for_fastapi.append(Import(from_='typing', import_="Union"))
+                sorted_arguments.append(argument)
+
+        return sorted_arguments
 
     def parse_request_body(
         self,
@@ -527,13 +542,16 @@ def _collapse_root_model(self, data_type: DataType) -> DataType:
         reference = data_type.reference
         import functools
 
-        if not (
-            reference
-            and (
-                len(reference.children) == 1
-                or functools.reduce(lambda a, b: a == b, reference.children)
-            )
-        ):
+        try:
+            if not (
+                reference
+                and (
+                    len(reference.children) == 0
+                    or functools.reduce(lambda a, b: a == b, reference.children)
+                )
+            ):
+                return data_type
+        except RecursionError:
             return data_type
         source = reference.source
         if not isinstance(source, CustomRootType):

tests/data/expected/openapi/default_template/duplicate_param/main.py

@@ -0,0 +1,24 @@
+# generated by fastapi-codegen:
+#   filename:  duplicate_param.yaml
+#   timestamp: 2020-06-19T00:00:00+00:00
+
+from __future__ import annotations
+
+from typing import Union
+
+from fastapi import FastAPI
+from pydantic import constr
+
+app = FastAPI(
+    title='REST API',
+    version='0.0.1',
+    servers=[{'url': 'https://api.something.com/1'}],
+)
+
+
+@app.delete('/boards/{id}', response_model=None)
+def delete_boards_id(id: Union[str, constr(regex=r'^[0-9a-fA-F]{24}$')]) -> None:
+    """
+    Delete a Board
+    """
+    pass

tests/data/expected/openapi/default_template/duplicate_param/models.py

@@ -0,0 +1,3 @@
+# generated by fastapi-codegen:
+#   filename:  duplicate_param.yaml
+#   timestamp: 2020-06-19T00:00:00+00:00

tests/data/expected/openapi/default_template/recursion/main.py

@@ -0,0 +1,20 @@
+# generated by fastapi-codegen:
+#   filename:  recursion.yaml
+#   timestamp: 2020-06-19T00:00:00+00:00
+
+from __future__ import annotations
+
+from fastapi import FastAPI
+
+from .models import ID
+
+app = FastAPI(
+    title='REST API',
+    version='0.0.1',
+    servers=[{'url': 'https://api.something.com/1'}],
+)
+
+
+@app.get('/actions/{id}', response_model=None)
+def get_actions_id(id: ID) -> None:
+    pass

tests/data/expected/openapi/default_template/recursion/models.py

@@ -0,0 +1,32 @@
+# generated by fastapi-codegen:
+#   filename:  recursion.yaml
+#   timestamp: 2020-06-19T00:00:00+00:00
+
+from __future__ import annotations
+
+from typing import Optional
+
+from pydantic import BaseModel, Field, constr
+
+
+class ID(BaseModel):
+    __root__: constr(regex=r'^[0-9a-fA-F]{24}$') = Field(
+        ..., example='5abbe4b7ddc1b351ef961414'
+    )
+
+
+class Card(BaseModel):
+    id: Optional[ID] = None
+
+
+class Board(BaseModel):
+    id: Optional[ID] = None
+
+
+class Data(BaseModel):
+    card: Optional[Card] = None
+    board: Optional[Board] = None
+
+
+class Action(BaseModel):
+    data: Optional[Data] = None

tests/data/openapi/default_template/duplicate_param.yaml

@@ -0,0 +1,39 @@
+openapi: 3.0.0
+info:
+  title: REST API
+  version: 0.0.1
+servers:
+  - url: https://api.something.com/1
+components:
+  securitySchemes: {}
+  schemas:
+    ID:
+      type: string
+      pattern: ^[0-9a-fA-F]{24}$
+      example: 5abbe4b7ddc1b351ef961414
+  responses: {}
+paths:
+  /boards/{id}:
+    parameters:
+      - name: id
+        in: path
+        description: ''
+        required: true
+        schema:
+          $ref: '#/components/schemas/ID'
+    delete:
+      tags: []
+      summary: Delete a Board
+      description: Delete a board.
+      operationId: delete-boards-id
+      parameters:
+        - name: id
+          in: path
+          description: The id of the board to delete
+          required: true
+          schema:
+            type: string
+      deprecated: false
+      responses:
+        '200':
+          description: Success

tests/data/openapi/default_template/recursion.yaml

@@ -0,0 +1,43 @@
+openapi: 3.0.0
+info:
+  title: REST API
+  version: 0.0.1
+servers:
+  - url: https://api.something.com/1
+components:
+  schemas:
+    Action:
+      type: object
+      properties:
+        data:
+          type: object
+          properties:
+            card:
+              type: object
+              properties:
+                id:
+                  type: string
+                  $ref: '#/components/schemas/ID'
+            board:
+              type: object
+              properties:
+                id:
+                  type: string
+                  $ref: '#/components/schemas/ID'
+    ID:
+      type: string
+      pattern: ^[0-9a-fA-F]{24}$
+      example: 5abbe4b7ddc1b351ef961414
+paths:
+  /actions/{id}:
+    parameters:
+      - name: id
+        in: path
+        description: The ID of the Action
+        required: true
+        schema:
+          $ref: '#/components/schemas/ID'
+    get:
+      responses:
+        '200':
+          description: Success