Skip to content

Commit 2890bd4

Browse files
committed
refactor: test_ranger_parameters
1 parent b8d314f commit 2890bd4

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

tests/test_general_optimizer_parameters.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -84,13 +84,6 @@ def test_momentum(optimizer_name):
8484
optimizer(None, momentum=-1e-3)
8585

8686

87-
@pytest.mark.parametrize('optimizer_name', ['ranger'])
88-
def test_lookahead_k(optimizer_name):
89-
optimizer = load_optimizer(optimizer_name)
90-
with pytest.raises(ValueError):
91-
optimizer(None, k=-1)
92-
93-
9487
@pytest.mark.parametrize('optimizer_name', ['nero', 'apollo', 'sm3', 'msvag', 'ranger21'])
9588
def test_beta(optimizer_name):
9689
optimizer = load_optimizer(optimizer_name)

tests/test_optimizer_parameters.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,3 +222,15 @@ def test_apollo_parameters():
222222
# test weight_decay_type
223223
with pytest.raises(ValueError):
224224
opt(None, weight_decay_type='dummy')
225+
226+
227+
def test_ranger_parameters():
228+
opt = load_optimizer('ranger')
229+
230+
# test ema ratio `alpha`
231+
with pytest.raises(ValueError):
232+
opt(None, alpha=-0.1)
233+
234+
# test lookahead step `k`
235+
with pytest.raises(ValueError):
236+
opt(None, k=-1)

0 commit comments

Comments
 (0)