update: get_optimizer_parameters

kozistr · kozistr · commit 9896bf520ca3 · 2023-02-18T15:56:48.000+09:00
diff --git a/pytorch_optimizer/optimizer/utils.py b/pytorch_optimizer/optimizer/utils.py
@@ -184,10 +184,13 @@ def get_optimizer_parameters(
 
     return [
         {
-            'params': [p for n, p in model_or_parameter if not any(nd in n for nd in wd_ban_list)],
+            'params': [p for n, p in model_or_parameter if p.requires_grad and not any(nd in n for nd in wd_ban_list)],
             'weight_decay': weight_decay,
         },
-        {'params': [p for n, p in model_or_parameter if any(nd in n for nd in wd_ban_list)], 'weight_decay': 0.0},
+        {
+            'params': [p for n, p in model_or_parameter if p.requires_grad and any(nd in n for nd in wd_ban_list)],
+            'weight_decay': 0.0,
+        },
     ]
 
 

Original file line number	Diff line number	Diff line change
`@@ -184,10 +184,13 @@ def get_optimizer_parameters(`
`184`	`184`
`185`	`185`	`return [`
`186`	`186`	`{`
`187`		`- 'params': [p for n, p in model_or_parameter if not any(nd in n for nd in wd_ban_list)],`
	`187`	`+ 'params': [p for n, p in model_or_parameter if p.requires_grad and not any(nd in n for nd in wd_ban_list)],`
`188`	`188`	`'weight_decay': weight_decay,`
`189`	`189`	`},`
`190`		`- {'params': [p for n, p in model_or_parameter if any(nd in n for nd in wd_ban_list)], 'weight_decay': 0.0},`
	`190`	`+ {`
	`191`	`+ 'params': [p for n, p in model_or_parameter if p.requires_grad and any(nd in n for nd in wd_ban_list)],`
	`192`	`+ 'weight_decay': 0.0,`
	`193`	`+ },`
`191`	`194`	`]`
`192`	`195`
`193`	`196`