Avoid a vector copy in 'join'.

Kasper Peeters · Kasper Peeters · commit 3628efa521d5 · 2023-12-01T20:35:41.000Z
diff --git a/core/pythoncdb/py_ex.cc b/core/pythoncdb/py_ex.cc
@@ -132,7 +132,7 @@ namespace cadabra {
 			}
 		}
 
-   Ex_ptr Ex_join(std::vector<Ex_ptr> exs)
+   Ex_ptr Ex_join(const std::vector<Ex_ptr>& exs)
 		{
 		auto ret = std::make_shared<Ex>("\\comma");
 

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ namespace cadabra {`
`132`	`132`	`}`
`133`	`133`	`}`
`134`	`134`
`135`		`- Ex_ptr Ex_join(std::vector<Ex_ptr> exs)`
	`135`	`+ Ex_ptr Ex_join(const std::vector<Ex_ptr>& exs)`
`136`	`136`	`{`
`137`	`137`	`auto ret = std::make_shared<Ex>("\\comma");`
`138`	`138`