Skip to content

Commit d16e932

Browse files
author
Kasper Peeters
committed
Fixes to build/run on Apple silicon.
1 parent b0ba2db commit d16e932

File tree

7 files changed

+24
-15
lines changed

7 files changed

+24
-15
lines changed

CMakeLists.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
set(CMAKE_LEGACY_CYGWIN_WIN32 0)
22
set(CADABRA_CMAKE_VERSION 3.1)
33

4+
# Policy settings for CMake to resolve ambiguities.
5+
6+
cmake_policy(SET CMP0042 NEW)
7+
cmake_policy(SET CMP0054 NEW)
8+
cmake_policy(SET CMP0127 NEW)
9+
410
cmake_minimum_required(VERSION ${CADABRA_CMAKE_VERSION})
511
if (${CMAKE_VERSION} VERSION_LESS "3.8.0")
612
set(CMAKE_CXX_STANDARD 14)

README.rst

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -327,12 +327,7 @@ macOS
327327

328328
Cadabra builds with the standard Apple compiler, but in order to build
329329
on macOS you need a number of packages from Homebrew (see
330-
https://brew.sh). Quite a few Homebrew installations have broken
331-
permissions; best to first do::
332-
333-
sudo chown -R ${USER}:admin /usr/local/
334-
335-
to clean that up. Then install the required dependencies with::
330+
https://brew.sh). Install the required dependencies with::
336331

337332
brew install cmake boost pcre gmp python3
338333
brew install pkgconfig
@@ -344,13 +339,17 @@ that.
344339

345340
You also need a TeX installation such as MacTeX,
346341
https://tug.org/mactex/ . *Any* TeX will do, as long as 'latex' and
347-
'dvipng' are available. Make sure to *install TeX* before attempting
348-
to build Cadabra, otherwise the Cadabra style files will not be
349-
installed in the appropriate place. Make sure 'latex' works from the
350-
terminal in which you will build Cadabra.
342+
'dvipng' are available, so you simply do::
343+
344+
brew install mactex
345+
346+
Make sure to *install TeX* before attempting to build Cadabra,
347+
otherwise the Cadabra style files will not be installed in the
348+
appropriate place. Make sure 'latex' works from the terminal in which
349+
you will build Cadabra.
351350

352351
You can build against an Anaconda Python installation (in case you
353-
prefer Anaconda over the Homebrew Python); cmake will automaticaly
352+
prefer Anaconda over the Homebrew Python); cmake will automatically
354353
pick this up if available.
355354

356355
You need to clone the cadabra2 git repository (if you download the

cmake/policies.cmake

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,6 @@ endif()
77
if (POLICY CMP0054)
88
cmake_policy(SET CMP0054 NEW)
99
endif()
10+
if (POLICY CMP0127)
11+
cmake_policy(SET CMP0127 NEW)
12+
endif()

cmake/version.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
set(CADABRA_VERSION_MAJOR 2)
22
set(CADABRA_VERSION_MINOR 3)
3-
set(CADABRA_VERSION_PATCH 7)
4-
set(CADABRA_VERSION_TWEAK 6)
3+
set(CADABRA_VERSION_PATCH 8)
4+
set(CADABRA_VERSION_TWEAK 0)
55
set(COPYRIGHT_YEARS "2001-2021")
66
math(EXPR SYSTEM_BITS "${CMAKE_SIZEOF_VOID_P} * 8")
77
find_program(GIT git PATHS ${GIT_DIR})

config/install_script.iss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
; SEE THE DOCUMENTATION FOR DETAILS ON CREATING INNO SETUP SCRIPT FILES!
33

44
#define MyAppName "Cadabra2"
5-
#define MyAppVersion "2.3.7"
5+
#define MyAppVersion "2.3.8"
66
#define MyAppPublisher "Kasper Peeters"
77
#define MyAppURL "https://www.cadabra.science/"
88
#define MyAppExeName "cadabra2-gtk.exe"

core/properties/Indices.hh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ namespace cadabra {
1515
return "name";
1616
};
1717
virtual match_t equals(const property *) const override;
18-
virtual void validate(const Kernel&, const Ex&) const;
18+
virtual void validate(const Kernel&, const Ex&) const override;
1919

2020
// virtual void display(std::ostream&) const override;
2121
virtual void latex(std::ostream&) const override;

tests/components.cdb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -757,6 +757,7 @@ def test37():
757757
complete(ss, $gt$)
758758
ex:= g;
759759
substitute(ex, ss)
760+
simplify(ex)
760761
tst:= -r**4 \sin(\theta)**2 - @(ex);
761762
assert(tst==0)
762763
print("Test 37 passed")

0 commit comments

Comments
 (0)