Cleanup patch, make tests work again.

Author: kpeeters

core/algorithms/canonicalise.cc

@@ -59,7 +59,9 @@ bool canonicalise::remove_traceless_traces(iterator& it)
 				bool incremented_now=false;
 				auto ind=kernel.properties.get<Indices>(indit, true);
 				if(ind) {
-					if(ind->set_name==trl->index_set_name) {
+					// The indexs need to be in the set for which the object is
+					// traceless (if specified, otherwise accept all).
+					if(ind->set_name==trl->index_set_name || trl->index_set_name=="") {
 						incremented_now=true;
 						++ihits;
 						}

core/properties/Traceless.hh

@@ -8,7 +8,7 @@ namespace cadabra {
 	class Traceless : virtual public property {
 		public:
 			virtual ~Traceless() {};
-			virtual std::string name() const;
+			virtual std::string name() const override;
 			virtual bool        parse(Kernel&, keyval_t&) override;
 
 			std::string index_set_name; // refers to Indices::set_name

core/properties/WeylTensor.cc

@@ -23,7 +23,7 @@ std::string WeylTensor::name() const
 	}
 
 // Traceless and TableauSymetry args are overwritten elsewhere
-bool WeylTensor::parse(Kernel&, keyval_t& keyvals)
+bool WeylTensor::parse(Kernel&, keyval_t& )
 	{
 	return true;
 	}

tests/implicit.cdb

@@ -51,7 +51,7 @@ def test04():
     A::Traceless(indices=spinor);
     B::Traceless(indices=vector);
     ex:=Tr( A ) + Tr( B );
-    canonicalise(_);
+    canonicalise(_)
     tst:= Tr( B ) - @(ex);
     assert(tst==0)
     print("Test 04 passed")
@@ -98,7 +98,7 @@ def test08():
     {A,B}::AntiCommuting;
     ex:=(A)_{a b} (B)_{b a};
     combine(_)
-    tst:= (-B A)_{b b} - @(ex);
+    tst:= \indexbracket{-B A}_{b b} - @(ex);
     assert(tst==0)
     print("Test 08 passed")
 
@@ -133,7 +133,7 @@ def test11():
     __cdbkernel__=create_scope()
     {a,b,c}::Indices(vector);
     ex:=(B)_{b c} (A)_{a b};
-    combine(_);
+    combine(_)
     tst:= (A B)_{a c} - @(ex);
     assert(tst==0)
     print("Test 11 passed")
@@ -148,8 +148,8 @@ def test12():
     B::ImplicitIndex(B_{a b});
     {A_{a b}, B_{a b}, C, D}::AntiCommuting;
     ex:=Tr( A C B D );
-    untrace(_);
-    sort_product(_);
+    untrace(_)
+    sort_product(_)
     tst:= -C D Tr( A B ) - @(ex);
     assert(tst==0)
     print("Test 12 passed")
@@ -164,7 +164,7 @@ def test13():
     B::ImplicitIndex(B_{a b});
     {A_{a b}, B_{a b}}::AntiCommuting;
     ex:=Tr( B A );
-    sort_product(_);
+    sort_product(_)
     tst:= Tr( -A B ) - @(ex);
     assert(tst==0)
     print("Test 13 passed")
@@ -175,7 +175,7 @@ def test14():
     __cdbkernel__=create_scope()
     {A,B,C}::ImplicitIndex;
     ex:=(B A C)_{a a};
-    sort_product(_);
+    sort_product(_)
     tst:= (A C B)_{a a} - @(ex);
     assert(tst==0)
     print("Test 14 passed")