isolate dependencies for tests and examples (#566)

* isolate dependencies for tests and examples

If the dependencies for tests and examples are leaked into the
core sdk module, it will make the consumers hard or impossible to
use when there is a k8s dependency skew.

* fix linter

Author: Mengqi Yu

go/Makefile

@@ -23,7 +23,7 @@ fmt: $(MODULES)
 lint: $(MODULES)
 	@for f in $(^D); do \
 	(cd $$f; echo "Checking golangci-lint $$f"; \
-	(which $(GOPATH)/bin/golangci-lint || go get github.com/golangci/golangci-lint/cmd/[email protected]); \
+	(which $(GOPATH)/bin/golangci-lint || go install github.com/golangci/golangci-lint/cmd/[email protected]); \
 	$(GOPATH)/bin/golangci-lint run ./...); \
 	done
 

go/fn/const.go

@@ -39,5 +39,5 @@ const (
 	ConfigPrefix string = "config.kubernetes.io/"
 
 	// KptLocalConfig marks a KRM resource to be skipped from deploying to the cluster via `kpt live apply`.
-	KptLocalConfig = ConfigPrefix  + "local-config"
+	KptLocalConfig = ConfigPrefix + "local-config"
 )

go/fn/examples/const.go

@@ -0,0 +1,19 @@
+// Copyright 2022 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package example
+
+const (
+	appsv1 = "apps/v1"
+)

go/fn/examples/example_builtin_function_test.go

@@ -1,3 +1,17 @@
+// Copyright 2022 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
 package example_test
 
 import (

go/fn/examples/example_generator_test.go

@@ -69,7 +69,7 @@ func generate(rl *fn.ResourceList) (bool, error) {
 
 func fetchDashboard(revision, id string) (string, error) {
 	url := fmt.Sprintf("https://grafana.com/api/dashboards/%s/revisions/%s/download", id, revision)
-	resp, err := http.Get(url)
+	resp, err := http.Get(url) // nolint:gosec
 	if err != nil {
 		return "", err
 	}

go/fn/examples/example_logger_injector_test.go

@@ -40,7 +40,8 @@ func injectLogger(rl *fn.ResourceList) (bool, error) {
 		return false, err
 	}
 	for i, obj := range rl.Items {
-		if obj.GetAPIVersion() == "apps/v1" && (obj.GetKind() == "Deployment" || obj.GetKind() == "StatefulSet" || obj.GetKind() == "DaemonSet" || obj.GetKind() == "ReplicaSet") {
+		if obj.IsGVK(appsv1, "Deployment") || obj.IsGVK(appsv1, "StatefulSet") ||
+			obj.IsGVK(appsv1, "DaemonSet") || obj.IsGVK(appsv1, "ReplicaSet") {
 			var containers []corev1.Container
 			obj.GetOrDie(&containers, "spec", "template", "spec", "containers")
 			foundTargetContainer := false

go/fn/examples/example_read_field_test.go

@@ -30,7 +30,7 @@ func Example_aReadField() {
 
 func readField(rl *fn.ResourceList) (bool, error) {
 	for _, obj := range rl.Items {
-		if obj.GetAPIVersion() == "apps/v1" && obj.GetKind() == "Deployment" {
+		if obj.IsGVK("apps/v1", "Deployment") {
 			var replicas int
 			obj.GetOrDie(&replicas, "spec", "replicas")
 			fn.Logf("replicas is %v\n", replicas)

go/fn/examples/example_validator_test.go

@@ -32,7 +32,8 @@ func Example_validator() {
 func validator(rl *fn.ResourceList) (bool, error) {
 	var results fn.Results
 	for _, obj := range rl.Items {
-		if obj.GetAPIVersion() == "apps/v1" && (obj.GetKind() == "Deployment" || obj.GetKind() == "StatefulSet" || obj.GetKind() == "DaemonSet" || obj.GetKind() == "ReplicaSet") {
+		if obj.IsGVK(appsv1, "Deployment") || obj.IsGVK(appsv1, "StatefulSet") ||
+			obj.IsGVK(appsv1, "DaemonSet") || obj.IsGVK(appsv1, "ReplicaSet") {
 			var runAsNonRoot bool
 			obj.GetOrDie(&runAsNonRoot, "spec", "template", "spec", "securityContext", "runAsNonRoot")
 			if !runAsNonRoot {

go/fn/examples/go.mod

@@ -0,0 +1,45 @@
+module github.com/GoogleContainerTools/kpt-functions-sdk/go/fn/examples
+
+go 1.17
+
+replace github.com/GoogleContainerTools/kpt-functions-sdk/go/fn v0.0.0 => ../
+
+require (
+	github.com/GoogleContainerTools/kpt-functions-sdk/go/fn v0.0.0
+	k8s.io/api v0.23.4
+	k8s.io/apimachinery v0.23.4
+	sigs.k8s.io/kustomize/kyaml v0.13.6
+)
+
+require (
+	github.com/PuerkitoBio/purell v1.1.1 // indirect
+	github.com/PuerkitoBio/urlesc v0.0.0-20170810143723-de5bf2ad4578 // indirect
+	github.com/davecgh/go-spew v1.1.1 // indirect
+	github.com/go-errors/errors v1.0.1 // indirect
+	github.com/go-logr/logr v1.2.0 // indirect
+	github.com/go-openapi/jsonpointer v0.19.5 // indirect
+	github.com/go-openapi/jsonreference v0.19.3 // indirect
+	github.com/go-openapi/swag v0.19.5 // indirect
+	github.com/gogo/protobuf v1.3.2 // indirect
+	github.com/google/go-cmp v0.5.5 // indirect
+	github.com/google/gofuzz v1.1.0 // indirect
+	github.com/json-iterator/go v1.1.12 // indirect
+	github.com/mailru/easyjson v0.7.0 // indirect
+	github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
+	github.com/modern-go/reflect2 v1.0.2 // indirect
+	github.com/monochromegane/go-gitignore v0.0.0-20200626010858-205db1a8cc00 // indirect
+	github.com/pkg/errors v0.9.1 // indirect
+	github.com/pmezard/go-difflib v1.0.0 // indirect
+	github.com/stretchr/testify v1.7.0 // indirect
+	github.com/xlab/treeprint v0.0.0-20181112141820-a009c3971eca // indirect
+	golang.org/x/net v0.0.0-20211209124913-491a49abca63 // indirect
+	golang.org/x/text v0.3.7 // indirect
+	gopkg.in/inf.v0 v0.9.1 // indirect
+	gopkg.in/yaml.v2 v2.4.0 // indirect
+	gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b // indirect
+	k8s.io/klog/v2 v2.30.0 // indirect
+	k8s.io/kube-openapi v0.0.0-20211115234752-e816edb12b65 // indirect
+	k8s.io/utils v0.0.0-20211116205334-6203023598ed // indirect
+	sigs.k8s.io/json v0.0.0-20211020170558-c049b76a60c6 // indirect
+	sigs.k8s.io/structured-merge-diff/v4 v4.2.1 // indirect
+)