parse results in resourceList (#571)

Author: Mengqi Yu

go/fn/resourcelist.go

@@ -63,8 +63,8 @@ func CheckResourceDuplication(rl *ResourceList) error {
 	idMap := map[yaml.ResourceIdentifier]struct{}{}
 	for _, obj := range rl.Items {
 		id := obj.resourceIdentifier()
-		if _, ok := idMap[*id]; ok{
-				return fmt.Errorf("duplicate Resource(apiVersion=%v, kind=%v, Namespace=%v, Name=%v)",
+		if _, ok := idMap[*id]; ok {
+			return fmt.Errorf("duplicate Resource(apiVersion=%v, kind=%v, Namespace=%v, Name=%v)",
 				obj.GetAPIVersion(), obj.GetKind(), obj.GetNamespace(), obj.GetName())
 		}
 		idMap[*id] = struct{}{}
@@ -96,12 +96,25 @@ func ParseResourceList(in []byte) (*ResourceList, error) {
 	}
 	objectItems, err := items.Elements()
 	if err != nil {
-		return nil, fmt.Errorf("failed extract objects from items: %w", err)
+		return nil, fmt.Errorf("failed to extract objects from items: %w", err)
 	}
 	for i := range objectItems {
 		rl.Items = append(rl.Items, asKubeObject(objectItems[i]))
 	}
 
+	res, found, err := rlObj.obj.GetNestedSlice("results")
+	if err != nil {
+		return nil, fmt.Errorf("failed when tried to get results: %w", err)
+	}
+	if found {
+		var results Results
+		err = res.Node().Decode(&results)
+		if err != nil {
+			return nil, fmt.Errorf("failed to decode results: %w", err)
+		}
+		rl.Results = results
+	}
+
 	return rl, nil
 }
 

go/fn/resourcelist_test.go

@@ -1,6 +1,10 @@
 package fn
 
-import "testing"
+import (
+	"testing"
+
+	"github.com/google/go-cmp/cmp"
+)
 
 var dupResourceInput = []byte(`
 apiVersion: config.kubernetes.io/v1
@@ -24,6 +28,39 @@ func TestCheckResourceDuplication(t *testing.T) {
 	}
 	expectErr := "duplicate Resource(apiVersion=v1, kind=Namespace, Namespace=, Name=example)"
 	if err.Error() != expectErr {
-		t.Errorf("expect CheckResourceDuplication to fail; got %v, want %v", err ,expectErr)
+		t.Errorf("expect CheckResourceDuplication to fail; got %v, want %v", err, expectErr)
+	}
+}
+
+func TestParseResourceListResults(t *testing.T) {
+	rl, err := ParseResourceList([]byte(`
+apiVersion: config.kubernetes.io/v1
+kind: ResourceList
+items:
+- apiVersion: v1
+  kind: Namespace
+  metadata:
+    name: example
+results:
+- message: foo
+  severity: error
+- message: bar
+  severity: warning
+`))
+	if err != nil {
+		t.Fatalf("unexpected error: %v", err)
+	}
+	expected := Results{
+		{
+			Message:  "foo",
+			Severity: Error,
+		},
+		{
+			Message:  "bar",
+			Severity: Warning,
+		},
+	}
+	if !cmp.Equal(expected, rl.Results) {
+		t.Fatalf("unexpected diff: %v", cmp.Diff(expected, rl.Results))
 	}
 }