Add getFunctionConfigMap function (#164)

* Add getFunctionConfigDataOrThrow function

* Address review comments

* Remove if statement

* Remove intermediate variable

Author: prachirp

ts/kpt-functions/src/types.ts

@@ -166,6 +166,33 @@ export class Configs {
     return this.functionConfig;
   }
 
+  /**
+   * Returns the map of data values if functionConfig is of kind ConfigMap.
+   *
+   * Throws a FunctionConfigError if functionConfig is undefined OR
+   * if the kind is not a v1/ConfigMap.
+   */
+  getFunctionConfigMap() {
+    const cm = this.getFunctionConfig();
+    if (cm === undefined) {
+      throw new FunctionConfigError(
+        `functionConfig expected, instead undefined`
+      );
+    }
+    if (!isConfigMap(cm)) {
+      throw new FunctionConfigError(
+        `functionConfig expected to be of kind ConfigMap, instead got: ${cm.kind}`
+      );
+    }
+    const configMap = new Map<string, string>();
+    for (const key in cm.data) {
+      if (cm.data.hasOwnProperty(key)) {
+        configMap.set(key, cm.data[key]);
+      }
+    }
+    return configMap;
+  }
+
   /**
    * Returns the value for the given key if functionConfig is of kind ConfigMap.
    *
@@ -177,16 +204,7 @@ export class Configs {
    * @key key The key in the 'data' field in the ConfigMap object given as the functionConfig.
    */
   getFunctionConfigValue(key: string): string | undefined {
-    const cm = this.functionConfig;
-    if (!cm) {
-      return undefined;
-    }
-    if (!isConfigMap(cm)) {
-      throw new FunctionConfigError(
-        `functionConfig expected to be of kind ConfigMap, instead got: ${cm.kind}`
-      );
-    }
-    return cm.data && cm.data[key];
+    return this.getFunctionConfigMap().get(key);
   }
 
   /**

ts/kpt-functions/src/types_test.ts

@@ -248,8 +248,12 @@ describe('functionConfig', () => {
         k2: 'v2',
       },
     };
+    const configMap = new Map<string, string>();
+    configMap.set('k1', 'v1');
+    configMap.set('k2', 'v2');
     const configs = new Configs(undefined, cm);
     expect(configs.getFunctionConfig()).toEqual(cm);
+    expect(configs.getFunctionConfigMap()).toEqual(configMap);
     expect(configs.getFunctionConfigValue('k1')).toEqual('v1');
     expect(configs.getFunctionConfigValue('k2')).toEqual('v2');
     expect(configs.getFunctionConfigValue('k3')).toBeUndefined();
@@ -260,14 +264,16 @@ describe('functionConfig', () => {
   it('no object', () => {
     const configs = new Configs(undefined);
     expect(configs.getFunctionConfig()).toBeUndefined();
-    expect(configs.getFunctionConfigValue('k3')).toBeUndefined();
+    expect(() => configs.getFunctionConfigMap()).toThrow();
+    expect(() => configs.getFunctionConfigValue('k3')).toThrow();
     expect(() => configs.getFunctionConfigValueOrThrow('k3')).toThrow();
   });
 
   it('other kinds', () => {
     const r1 = new Role('alice');
     const configs = new Configs(undefined, r1);
     expect(configs.getFunctionConfig()).toEqual(r1);
+    expect(() => configs.getFunctionConfigMap()).toThrow();
     expect(() => configs.getFunctionConfigValue('k1')).toThrow();
     expect(() => configs.getFunctionConfigValueOrThrow('k1')).toThrow();
   });