Add short flags and usage to gatekeeper function.

Also add a release workflow for pushing to gcr.

Author: frankfarzan

.github/workflows/release-gatekeeper-function.yaml

@@ -0,0 +1,37 @@
+name: release-gatekeeper-function
+
+on:
+  push:
+    tags:
+      - release-gatekeeper-function-*
+
+jobs:
+  release:
+    runs-on: ubuntu-latest
+    env:
+      GOPATH: /home/runner/work/kpt-functions-sdk/go
+      GO111MODULE: off
+    steps:
+    - name: Set up gcloud
+      uses: GoogleCloudPlatform/github-actions/setup-gcloud@master
+      with:
+          version: '275.0.0'
+          service_account_email: ${{ secrets.GCP_SA_EMAIL }}
+          service_account_key: ${{ secrets.GCP_SA_KEY }}
+    - name: Set up Go 1.13
+      uses: actions/setup-go@v1
+      with:
+        go-version: 1.13
+      id: go
+    - name: Check out code into GOPATH
+      uses: actions/checkout@v1
+      with:
+        path: go/src/github.com/${{ github.repository }}
+    - name: Build, Test, Lint
+      run: |
+        cd go
+        make all
+    - name: Push to container registry
+      run: |
+        cd go
+        TAG=latest ./scripts/publish-functions.sh

go/Makefile

@@ -24,9 +24,6 @@ test-e2e:
 vet:
 	go vet ./...
 
-publish-functions: all
-	./scripts/publish-functions.sh
-
 build-typegen: fix fmt test lint
 	env GOOS=linux GOARCH=amd64 go build -o $(OUT_DIR)/linux/typegen ./cmd/typegen
 	env GOOS=darwin GOARCH=amd64 go build -o $(OUT_DIR)/darwin/typegen ./cmd/typegen

go/cmd/gatekeeper_validate/gatekeeper_validate.go

@@ -19,6 +19,12 @@ import (
 	"github.com/GoogleContainerTools/kpt-functions-sdk/go/pkg/functions/gatekeeper"
 )
 
+const usage = `
+Evaluates OPA constraints against input configuration objects.
+
+Constraints themselves are also declared as part of the input.
+`
+
 func main() {
-	runners.RunFunc(gatekeeper.Validate)
+	runners.RunFunc(gatekeeper.Validate, usage)
 }

go/cmd/require_namespace_label/require_namespace_label.go

@@ -22,59 +22,42 @@ import (
 	"github.com/spf13/cobra"
 )
 
-const (
-	inputFlag  = "input"
-	outputFlag = "output"
-	jsonFlag   = "json"
-)
-
 var (
 	input   string
 	output  string
 	useJSON bool
 )
 
 func addInputFlag(cmd *cobra.Command) {
-	cmd.Flags().StringVar(&input, inputFlag, io.Stdin,
-		`Path to the input JSON file`)
+	cmd.Flags().StringVarP(&input, "input", "i", io.Stdin,
+		`path to the input JSON file`)
 }
 
 func addOutputFlag(cmd *cobra.Command) {
-	cmd.Flags().StringVar(&output, outputFlag, io.Stdout,
-		`Path to the output JSON file`)
+	cmd.Flags().StringVarP(&output, "output", "o", io.Stdout,
+		`path to the output JSON file`)
 }
 
 func addFormatFlag(cmd *cobra.Command) {
-	cmd.Flags().BoolVar(&useJSON, jsonFlag, false,
+	cmd.Flags().BoolVar(&useJSON, "json", false,
 		`input and output is JSON instead of YAML`)
 }
 
-func addProps(cmd *cobra.Command, propNames []string) types.Props {
-	props := types.Props{}
-	for _, propName := range propNames {
-		empty := ""
-		props[propName] = &empty
-		cmd.Flags().StringVar(props[propName], propName, "", "")
-	}
-	return props
-}
-
 func getFormat() io.Format {
 	if useJSON {
 		return io.JSON
 	}
 	return io.YAML
 }
 
-// RunFunc runs a ConfigFunc with the specified property names.
-func RunFunc(f types.ConfigFunc, propNames ...string) {
-	cmd := &cobra.Command{}
+// RunFunc runs a ConfigFunc.
+func RunFunc(f types.ConfigFunc, usage string) {
+	cmd := &cobra.Command{Long: usage}
 	//TODO(b/138231979): Make text output match more closely with go vs typescript.
 
 	addInputFlag(cmd)
 	addOutputFlag(cmd)
 	addFormatFlag(cmd)
-	props := addProps(cmd, propNames)
 
 	cmd.RunE = func(cmd *cobra.Command, args []string) error {
 		// Since printing the usage message since we know all required fields are present.
@@ -85,7 +68,7 @@ func RunFunc(f types.ConfigFunc, propNames ...string) {
 			return err
 		}
 
-		err = f(&configs, props)
+		err = f(&configs)
 		if err != nil {
 			return err
 		}

go/cmd/require_namespace_label/testing/missing_label.json

@@ -29,13 +29,8 @@ type KubernetesObject interface {
 // functions.
 type Configs []KubernetesObject
 
-//TODO(b/138233382): Write Source/Sink funcs and runners.
-
 // ConfigFunc is a type of kpt function that consumes Configs and potentially mutates it.
-type ConfigFunc func(configs *Configs, props Props) error
-
-// Props is a collection of properties to configure kpt functions.
-type Props map[string]*string
+type ConfigFunc func(configs *Configs) error
 
 // ConfigError represents a non-exceptional issue with configuration.
 //

go/pkg/framework/runners/runners.go

@@ -86,7 +86,7 @@ func gatherConstraints(configs *types.Configs) ([]types.KubernetesObject, error)
 
 // Validate makes sure the configs passed to it comply with any Constraints and
 // Constraint Templates present in the list of configs
-func Validate(configs *types.Configs, _ types.Props) error {
+func Validate(configs *types.Configs) error {
 	client, err := createClient()
 	if err != nil {
 		return err