Skip to content

Commit 92e815f

Browse files
jakobwkpy3
authored andcommitted
[JavaScript] Avoid undefined headers with skipDefaultUserAgent enabled (OpenAPITools#20792)
Prior to this commit, a JS client generated with skipDefaultUserAgent enabled results in a src/ApiClient.js file that doesn't define this.defaultHeaders. This breaks because this.defaultHeaders is later directly passed to a superagent request which expects an object and not undefined. Fixes OpenAPITools#20791.
1 parent ad25758 commit 92e815f

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

modules/openapi-generator/src/main/resources/Javascript/libraries/javascript/ApiClient.mustache

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ class ApiClient {
5656
}
5757

5858
<={{ }}=>
59-
{{^skipDefaultUserAgent}}
6059
{{#emitJSDoc}}
6160
/**
6261
* The default HTTP headers to be included for all API calls.
@@ -65,10 +64,11 @@ class ApiClient {
6564
*/
6665
{{/emitJSDoc}}
6766
this.defaultHeaders = {
67+
{{^skipDefaultUserAgent}}
6868
'User-Agent': '{{{httpUserAgent}}}{{^httpUserAgent}}OpenAPI-Generator/{{projectVersion}}/Javascript{{/httpUserAgent}}'
69+
{{/skipDefaultUserAgent}}
6970
};
7071

71-
{{/skipDefaultUserAgent}}
7272
/**
7373
* The default HTTP timeout for all API calls.
7474
* @type {Number}

samples/client/petstore/javascript-es6/src/ApiClient.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,14 @@ class ApiClient {
5252
'bearer_test': {type: 'bearer'}, // JWT
5353
}
5454

55+
/**
56+
* The default HTTP headers to be included for all API calls.
57+
* @type {Array.<String>}
58+
* @default {}
59+
*/
60+
this.defaultHeaders = {
61+
};
62+
5563
/**
5664
* The default HTTP timeout for all API calls.
5765
* @type {Number}

0 commit comments

Comments
 (0)