Skip to content

Commit 66bb259

Browse files
committed
[opt-viewer] Allow users to set LLVM_HAVE_OPT_VIEWER_MODULES manually from the CMake
Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES so that if the user specifies the variable on the commandline it takes precedence. If not, fall back to the old logic Upstream-Status: Submitted [llvm#151845] Signed-off-by: Khem Raj <[email protected]>
1 parent ade3bd4 commit 66bb259

File tree

3 files changed

+15
-3
lines changed

3 files changed

+15
-3
lines changed

llvm/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ set(LLVM_COMMON_CMAKE_UTILS ${CMAKE_CURRENT_SOURCE_DIR}/../cmake)
77
include(${LLVM_COMMON_CMAKE_UTILS}/Modules/CMakePolicy.cmake
88
NO_POLICY_SCOPE)
99

10+
option(LLVM_HAVE_OPT_VIEWER_MODULES "Enable opt-viewer modules support" ON)
11+
1012
# Builds with custom install names and installation rpath setups may not work
1113
# in the build tree. Allow these cases to use CMake's default build tree
1214
# behavior by setting `LLVM_NO_INSTALL_NAME_DIR_FOR_BUILD_TREE` to do this.

llvm/cmake/config-ix.cmake

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -805,10 +805,17 @@ foreach(module ${PYTHON_MODULES})
805805
find_python_module(${module})
806806
endforeach()
807807

808-
if(PY_PYGMENTS_FOUND AND PY_PYGMENTS_LEXERS_C_CPP_FOUND AND PY_YAML_FOUND)
809-
set (LLVM_HAVE_OPT_VIEWER_MODULES 1)
808+
if(NOT DEFINED LLVM_HAVE_OPT_VIEWER_MODULES)
809+
if(PY_PYGMENTS_FOUND AND PY_PYGMENTS_LEXERS_C_CPP_FOUND AND PY_YAML_FOUND)
810+
set (LLVM_HAVE_OPT_VIEWER_MODULES 1)
811+
else()
812+
set (LLVM_HAVE_OPT_VIEWER_MODULES 0)
813+
endif()
814+
elseif(LLVM_HAVE_OPT_VIEWER_MODULES)
815+
# Use the user-provided value
816+
set(LLVM_HAVE_OPT_VIEWER_MODULES 1)
810817
else()
811-
set (LLVM_HAVE_OPT_VIEWER_MODULES 0)
818+
set(LLVM_HAVE_OPT_VIEWER_MODULES 0)
812819
endif()
813820

814821
function(llvm_get_host_prefixes_and_suffixes)

llvm/include/llvm/Config/config.h.cmake

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,9 @@
287287
/* Define to a function implementing strdup */
288288
#cmakedefine strdup ${strdup}
289289

290+
/* Define indicating opt-viewer modules */
291+
#cmakedefine LLVM_HAVE_OPT_VIEWER_MODULES
292+
290293
/* Whether GlobalISel rule coverage is being collected */
291294
#cmakedefine01 LLVM_GISEL_COV_ENABLED
292295

0 commit comments

Comments
 (0)