clang: Fix resource dir location for cross toolchains

When clang looks for the resources directory, it does so based on the binary
location and assumes that the containing directory is a sibling to lib. The
Yocto cross.bbclass defines the default bindir as
${exec_prefix}/bin/${CROSS_TARGET_SYS_DIR}. ex: /usr/bin/aarch64-poky-linux/.
This causes clang to form a path that looks like /usr/bin/lib/clang/...

As a fix for this, check the parent directory name. If that is "bin", then
use that directory's parent.

Upstream-Status: Pending

Signed-off-by: Jim Broadus <[email protected]>
Signed-off-by: Khem Raj <[email protected]>

Author: Jim Broadus

clang/lib/Options/OptionUtils.cpp

@@ -213,6 +213,7 @@ std::string clang::GetResourcesPath(StringRef BinaryPath) {
 
   // Dir is bin/ or lib/, depending on where BinaryPath is.
   StringRef Dir = llvm::sys::path::parent_path(BinaryPath);
+  StringRef LastDirName = llvm::sys::path::filename(Dir);
   SmallString<128> P(Dir);
 
   StringRef ConfiguredResourceDir(CLANG_RESOURCE_DIR);
@@ -229,9 +230,15 @@ std::string clang::GetResourcesPath(StringRef BinaryPath) {
     // With a static-library build of libclang, LibClangPath will contain the
     // path of the embedding binary, which for LLVM binaries will be in bin/.
     // ../lib gets us to lib/ in both cases.
-    P = llvm::sys::path::parent_path(Dir);
     // This search path is also created in the COFF driver of lld, so any
     // changes here also needs to happen in lld/COFF/Driver.cpp
+
+    // OE cross toolchains are installed, by default, in a subdir of bin.
+    if (LastDirName == "bin") {
+      P = llvm::sys::path::parent_path(Dir);
+    } else {
+      P = llvm::sys::path::parent_path(llvm::sys::path::parent_path(Dir));
+    }
     llvm::sys::path::append(P, CLANG_INSTALL_LIBDIR_BASENAME, "clang",
                             CLANG_VERSION_MAJOR_STRING);
   }