Non-issue : Added variadic and spread operators of PHP5.6

Author: khelle

src/Channel/src/Router/RuleMatch/RuleNegate.php

@@ -34,6 +34,7 @@ public function __destruct()
      */
     public function __invoke($name, ProtocolInterface $protocol)
     {
-        return !call_user_func_array($this->rule, [ $name, $protocol ]);
+        $call = $this->rule;
+        return !$call($name, $protocol);
     }
 }

src/Config/src/Config.php

@@ -143,7 +143,7 @@ protected function overwrite($current, $new, $handler = null)
             $handler = $this->overwriteHandler;
         }
 
-        return call_user_func_array($handler, [ $current, $new ]);
+        return $handler($current, $new);
     }
 
     /**

src/Event/src/AsyncEventEmitterTrait.php

@@ -17,7 +17,7 @@ protected function attachOnListener($pointer, $event, callable $listener)
         return function() use($listener) {
             $args = func_get_args();
             $this->getLoop()->onTick(function() use($listener, $args) {
-                call_user_func_array($listener, $args);
+                $listener(...$args);
             });
         };
     }
@@ -32,7 +32,7 @@ protected function attachOnceListener($pointer, $event, callable $listener)
 
             $args = func_get_args();
             $this->getLoop()->onTick(function() use($listener, $args) {
-                call_user_func_array($listener, $args);
+                $listener(...$args);
             });
         };
     }
@@ -52,7 +52,7 @@ protected function attachTimesListener($pointer, $event, $limit, callable $liste
 
             $args = func_get_args();
             $this->getLoop()->onTick(function() use($listener, $args) {
-                call_user_func_array($listener, $args);
+                $listener(...$args);
             });
         };
     }

src/Event/src/BaseEventEmitterTrait.php

@@ -131,10 +131,10 @@ public function times($event, $limit, callable $listener)
     public function delay($event, $ticks, callable $listener)
     {
         $counter = 0;
-        return $this->on($event, function() use(&$counter, $event, $ticks, $listener) {
+        return $this->on($event, function(...$args) use(&$counter, $event, $ticks, $listener) {
             if (++$counter >= $ticks)
             {
-                call_user_func_array($listener, func_get_args());
+                $listener(...$args);
             }
         });
     }
@@ -145,10 +145,10 @@ public function delay($event, $ticks, callable $listener)
     public function delayOnce($event, $ticks, callable $listener)
     {
         $counter = 0;
-        return $this->times($event, $ticks, function() use(&$counter, $event, $ticks, $listener) {
+        return $this->times($event, $ticks, function(...$args) use(&$counter, $event, $ticks, $listener) {
             if (++$counter >= $ticks)
             {
-                call_user_func_array($listener, func_get_args());
+                $listener(...$args);
             }
         });
     }
@@ -159,10 +159,10 @@ public function delayOnce($event, $ticks, callable $listener)
     public function delayTimes($event, $ticks, $limit, callable $listener)
     {
         $counter = 0;
-        return $this->times($event, $ticks+$limit-1, function() use(&$counter, $event, $ticks, $listener) {
+        return $this->times($event, $ticks+$limit-1, function(...$args) use(&$counter, $event, $ticks, $listener) {
             if (++$counter >= $ticks)
             {
-                call_user_func_array($listener, func_get_args());
+                $listener(...$args);
             }
         });
     }
@@ -316,10 +316,10 @@ protected function attachOnListener($pointer, $event, callable $listener)
     protected function attachOnceListener($pointer, $event, callable $listener)
     {
         $emitter = $this;
-        return function() use($emitter, $listener, $event, $pointer) {
+        return function(...$args) use($emitter, $listener, $event, $pointer) {
             unset($emitter->eventListeners[$event][$pointer]);
 
-            return call_user_func_array($listener, func_get_args());
+            return $listener(...$args);
         };
     }
 
@@ -333,14 +333,13 @@ protected function attachOnceListener($pointer, $event, callable $listener)
     protected function attachTimesListener($pointer, $event, $limit, callable $listener)
     {
         $emitter = $this;
-        return function() use($emitter, $listener, $event, $pointer, &$limit) {
+        return function(...$args) use($emitter, $listener, $event, $pointer, &$limit) {
             if (--$limit === 0)
             {
                 unset($limit);
                 unset($emitter->eventListeners[$event][$pointer]);
             }
-
-            return call_user_func_array($listener, func_get_args());
+            return $listener(...$args);
         };
     }
 

src/Promise/src/Promise.php

@@ -136,13 +136,13 @@ public function spread(callable $onFulfilled = null, callable $onRejected = null
     {
         return $this->then(
             function($values) use($onFulfilled) {
-                return call_user_func_array($onFulfilled, (array) $values);
+                return $onFulfilled(...((array) $values));
             },
             function($rejections) use($onRejected) {
-                return call_user_func_array($onRejected, (array) $rejections);
+                return $onRejected(...((array) $rejections));
             },
             function($reasons) use($onCancel) {
-                return call_user_func_array($onCancel, (array) $reasons);
+                return $onCancel(...((array) $reasons));
             }
         );
     }

src/Promise/src/PromiseCancelled.php

@@ -103,7 +103,7 @@ public function spread(callable $onFulfilled = null, callable $onRejected = null
             null,
             null,
             function($reasons) use($onCancel) {
-                return call_user_func_array($onCancel, (array) $reasons);
+                return $onCancel(...((array) $reasons));
             }
         );
     }

src/Promise/src/PromiseFulfilled.php

@@ -89,7 +89,7 @@ public function spread(callable $onFulfilled = null, callable $onRejected = null
     {
         return $this->then(
             function($values) use($onFulfilled) {
-                return call_user_func_array($onFulfilled, (array) $values);
+                return $onFulfilled(...((array) $values));
             }
         );
     }

src/Promise/src/PromiseRejected.php

@@ -97,7 +97,7 @@ public function spread(callable $onFulfilled = null, callable $onRejected = null
         return $this->then(
             null,
             function($rejections) use($onRejected) {
-                return call_user_func_array($onRejected, (array) $rejections);
+                return $onRejected(...((array) $rejections));
             }
         );
     }