Merge branch 'jupyter-lsp:master' into master

Author: FlyingSamson

.github/ISSUE_TEMPLATE/bug_report.md

@@ -37,6 +37,7 @@ https://jupyterlab.readthedocs.io/en/latest/getting_started/issue.html
 - Operating System and version:
 - Browser and version:
 - JupyterLab version:
+- Language server and version:
 
 <details><summary>Required: installed server extensions</summary>
 <pre>
@@ -53,7 +54,7 @@ You may want to sanitize the paths in the output.
 </pre>
 </details>
 
-<!--The more content you provide, the more we can help!-->
+<!--The more content you provide, the more we can help! Please fill in the below:-->
 
 <details><summary>Troubleshoot Output</summary>
 <pre>

.github/workflows/job.test.yml

@@ -5,12 +5,19 @@ on:
     branches:
       - master
       - 2.x
+      - 3.x
   pull_request:
     branches:
       - master
       - 2.x
+      - 3.x
   workflow_dispatch:
 
+# TODO: might need to tweak `group`
+concurrency:
+  group: ${{ github.ref }}
+  cancel-in-progress: true
+
 defaults:
   run:
     shell: bash -l {0}
@@ -21,22 +28,24 @@ env:
   PIP_DISABLE_PIP_VERSION_CHECK: 1
   PYTHONUNBUFFERED: 1
 
+  ATEST_PROCESSES: 2
   ATEST_RETRIES: 3
   JLPM_CMD: jlpm --ignore-optional --prefer-offline --frozen-lockfile
 
   # Increase this value to reset all caches
-  CACHE_EPOCH: 2
-  JULIA_LANGSERVER: 3.2.0
+  CACHE_EPOCH: 4
+  JULIA_LANGSERVER: 4.1.0
 
 jobs:
   lint:
     name: jstest/lint
-    runs-on: ${{ matrix.os }}
+    runs-on: ${{ matrix.os }}-latest
     strategy:
       matrix:
-        os: [ubuntu-latest]
+        os: [ubuntu]
         nodejs: ['>=14,<15.0.0a0']
-        lab: ['>=3.0.0,<4.0.0a0']
+        lab: ['>=3.1.0,<4.0.0a0']
+        r: ['>=4']
     steps:
       - uses: actions/checkout@v2
 
@@ -77,7 +86,7 @@ jobs:
         with:
           path: '**/node_modules'
           key: |
-            ${{ env.CACHE_EPOCH }}-${{ runner.os }}-node-lint-${{ hashFiles('yarn.lock', 'requirements/github-actions.yml') }}
+            ${{ env.CACHE_EPOCH }}-${{ runner.os }}-node-build-${{ hashFiles('yarn.lock', 'requirements/github-actions.yml') }}
 
       - name: Cache yarn packages
         id: cache-yarn-packages
@@ -104,6 +113,9 @@ jobs:
       - name: Lint backend
         run: python scripts/lint.py
 
+      - name: 'Revert templated file (TODO: remove)'
+        run: git checkout requirements/github-actions.yml
+
       - name: Lint frontend
         run: jlpm lint:check
 
@@ -112,12 +124,13 @@ jobs:
 
   build:
     name: build
-    runs-on: ${{ matrix.os }}
+    runs-on: ${{ matrix.os }}-latest
     strategy:
       matrix:
-        os: [ubuntu-latest]
+        os: [ubuntu]
         nodejs: ['>=14,<15.0.0a0']
-        lab: ['>=3.0.0,<4.0.0a0']
+        lab: ['>=3.1.0,<4.0.0a0']
+        r: ['>=4']
     steps:
       - uses: actions/checkout@v2
 
@@ -204,35 +217,26 @@ jobs:
 
   acceptance:
     runs-on: ${{ matrix.os }}-latest
-    name: atest ${{ matrix.os }} py${{ matrix.python }}
+    name: atest ${{ matrix.os }} py${{ matrix.python }} r${{ matrix.r }}
     needs: [build]
     strategy:
       # TODO: maybe turn back on
       fail-fast: false
       matrix:
-        os: [ubuntu, macos, windows]
-        python: [3.6, 3.7, 3.8]
-        lab: ['>=3.0.0,<4.0.0a0']
+        os: ['ubuntu', 'macos', 'windows']
+        python: ['3.7', '3.10']
         include:
-          # if using 3.6, use an old node
-          - python: 3.6
+          # if using 3.7, use newer node, etc...
+          - python: '3.7'
             # Node 12 end-of-life: April 2022
             nodejs: '>=12,<13.0.0.a0'
-          # if using 3.7, use newer node, etc...
-          - python: 3.7
-            # Node 14 end-of-life: April 2023
-            nodejs: '>=14,<15.0.0.a0'
-          - python: 3.8
-            # TODO: switch to Node 16 once gets merged https://github.com/conda-forge/nodejs-feedstock/pull/189
-            # Node 15 end-of-life: June 2021
-            nodejs: '>=15,<16.0.0.a0'
-          # TODO: remove when mambaforge just works on setup-miniconda
-          - os: ubuntu
-            mambaforge: Linux-x86_64.sh
-          - os: macos
-            mambaforge: MacOSX-x86_64.sh
-          - os: windows
-            mambaforge: Windows-x86_64.exe
+            r: '<4'
+            lab: '>=3.1.0,<3.2'
+          - python: '3.10'
+            # Node 16 end-of-life: April 2024
+            nodejs: '>=16,<17.0.0.a0'
+            r: '>=4'
+            lab: '>=3.2.0,<4'
 
     steps:
       - uses: actions/checkout@v2
@@ -341,6 +345,12 @@ jobs:
       - name: Run browser tests
         run: python scripts/atest.py --exclude expect:fail
 
+      - name: Find and remove empty files
+        # https://github.com/actions/upload-artifact/issues/150
+        run: find ./atest/output -empty -delete
+        if: always()
+        shell: bash
+
       - name: Publish browser test output
         uses: actions/upload-artifact@v2
         with:
@@ -354,24 +364,34 @@ jobs:
     needs: [build, lint]
     strategy:
       fail-fast: false
+      max-parallel: 3
       matrix:
-        os: [ubuntu, macos, windows]
-        python: ['3.6', '3.9', 'pypy3']
+        os: ['ubuntu', 'macos', 'windows']
+        python: ['3.7', '3.8', '3.9', '3.10', 'pypy-3.7']
         exclude:
           - os: windows
-            python: pypy3
+            python: pypy-3.7
         include:
-          - python: '3.6'
-            dist: 'jupyter*lsp*.tar.gz'
-          - python: 'pypy3'
+          - python: '3.7'
             dist: 'jupyter*lsp*.tar.gz'
+            lab: '>=3.1,<3.2'
+          - python: '3.8'
+            dist: 'jupyter*lsp*.whl'
+            lab: '>=3.1,<3.2'
           - python: '3.9'
+            dist: 'jupyter*lsp*.tar.gz'
+            lab: '>=3.2,<3.3'
+          - python: '3.10'
             dist: 'jupyter*lsp*.whl'
-          - os: windows
+            lab: '>=3.2,<4'
+          - python: 'pypy-3.7'
+            dist: 'jupyter*lsp*.tar.gz'
+            lab: '>=3.2,<3.3'
+          - os: 'windows'
             py_cmd: python
-          - os: macos
+          - os: 'macos'
             py_cmd: python3
-          - os: ubuntu
+          - os: 'ubuntu'
             py_cmd: python
     steps:
       - name: Install Python
@@ -386,7 +406,7 @@ jobs:
       - name: Install the prerequisites
         run: ${{ matrix.py_cmd }} -m pip install pip wheel
       - name: Install the package
-        run: cd dist && ${{ matrix.py_cmd }} -m pip install -vv ${{ matrix.dist }}
+        run: cd dist && ${{ matrix.py_cmd }} -m pip install -vv ${{ matrix.dist }} 'jupyterlab${{ matrix.lab }}'
       - name: Validate environment
         run: |
           set -eux
@@ -401,16 +421,20 @@ jobs:
           jupyter server extension list 2>&1 | grep -ie "jupyter_lsp.*enabled" -
 
   source:
-    name: smoke source install ${{ matrix.os }}
+    name: smoke source install ${{ matrix.os }} py${{ matrix.python }} lab${{ matrix.lab }}
     runs-on: ${{ matrix.os }}-latest
     needs: [build]
     strategy:
       fail-fast: false
       matrix:
         os: [ubuntu]
-        python: ['3.6']
+        python: ['3.7', '3.10']
         nodejs: ['14']
-        lab: ['>=3.0.0,<4.0.0a0']
+        include:
+          - python: '3.7'
+            lab: '>=3.1,<3.2'
+          - python: '3.10'
+            lab: '>=3.2,<4'
     steps:
       - name: Install Python
         uses: actions/setup-python@v2
@@ -420,13 +444,13 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v2
         with:
-          node-version: ${{matrix.nodejs}}
+          node-version: ${{ matrix.nodejs }}
       - uses: actions/download-artifact@v2
         with:
           name: jupyterlab-lsp dist ${{ github.run_number }}
           path: ./dist
       - name: Install the prerequisites
-        run: python -m pip install pip wheel
+        run: python -m pip install --upgrade pip wheel setuptools
       - name: Install JupyterLab
         shell: bash -l {0}
         run: python -m pip install 'jupyterlab${{ matrix.lab }}'

.gitignore

@@ -110,13 +110,15 @@ node_modules
 *.tgz
 
 atest/output/
+.pabotsuitenames
 junit.xml
 coverage/
 .vscode/
 _*.d.ts
 _*.ts
 _build
 .virtual_documents/
+.idea/
 
 # Built labextensions
-python_packages/jupyterlab_lsp/jupyterlab_lsp/labextensions/
+python_packages/*/*/labextensions/

.readthedocs.yml

@@ -3,6 +3,11 @@ version: 2
 sphinx:
   configuration: docs/conf.py
 
+build:
+  os: ubuntu-20.04
+  tools:
+    python: mambaforge-4.10
+
 conda:
   environment: docs/rtd.yml
 

CHANGELOG.md

@@ -1,5 +1,96 @@
 ## Changelog
 
+### `@krassowski/jupyterlab-lsp 3.10.1` (2022-03-21)
+
+- bug fixes:
+  - fix navigation to files with names including characters which require encoding ([#758])
+  - fix omissions in the main settings schema for correct rendering in JupyterLab 3.3 Settings Editor UI ([#779])
+- maintenance
+  - make tests pass with new JupyterLab 3.3 ([#777])
+  - pin r-base version to fix Binder ([#766])
+  - pin node-gyp to fix CI on Windows ([#772])
+  - pin pytest-flake8 to fix CI
+  - update development/testing environment dependencies: urijs, typedoc, url-parse
+
+[#758]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/758
+[#766]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/766
+[#772]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/772
+[#777]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/777
+[#779]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/779
+
+### `@krassowski/jupyterlab-lsp 3.10.0` (2022-01-01)
+
+- features:
+  - enable pre-filtering of completion matches by default ([#735])
+  - add support for diagnostic tags: Deprecated, Unnecessary ([#736], [#737])
+- bug fixes:
+  - squash warnings and errors in web console ([#732])
+  - fix signature blur and fix formatting when no arguments are present ([#734])
+  - fixed with enabling of strict null checks:
+    - previously changing kernels always led to restarting of LSP connection, even if the kernel language did not change; now the connection will be retained if possible
+    - `markdownRenderer` is no longer implicitly required
+    - diagnostics sorting with missing values for `source` and `severity` was improved and missing values will be consistently shown at the end
+    - diagnostics placeholder was split into `Diagnostics are not available` and `No issues detected, great job!` which will now show up properly
+- maintenance:
+  - enable strict null checks and other strict settings ([#733])
+  - specify client capabilities in features instead of hard-coding them ([#738])
+  - bump minimum required JupyterLab version to 3.1 (`>=3.1.0,<4.0.0a0`)
+
+[#732]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/732
+[#733]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/733
+[#734]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/734
+[#735]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/735
+[#736]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/736
+[#737]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/737
+[#738]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/738
+
+### `@krassowski/code-jumpers 1.2.0` (2022-01-01)
+
+- maintenance:
+  - updates to API with respect to `null`/`undefined` values in course strict null checks activation ([#733])
+
+### `@krassowski/jupyterlab-lsp 3.9.3` (2021-12-19)
+
+- bug fixes:
+  - workaround upstream issue in merging translation ([#726], thanks @fcollonval)
+
+[#726]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/726
+
+### `@krassowski/jupyterlab-lsp 3.9.2` (2021-12-12)
+
+- bug fixes:
+  - prevent very long completion details text from extending the completer indefinitely ([#698])
+  - correct status translations ([#700], thanks @fcollonval)
+  - fix translations in status pop-up ([#703])
+  - workaround issue causing file rename when opening external files by jumping to them ([#712], thanks @jepcor97)
+  - fix sorting by "Line:Ch" and "Cell" in Diagnostics Panel ([#717])
+  - fix header border missing when scrolling in Diagnostics Panel ([#717])
+- documentation improvements:
+  - clarify that JupyterLab restart is needed after installation ([#714], thanks @3coins)
+
+[#698]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/698
+[#700]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/700
+[#703]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/703
+[#712]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/712
+[#714]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/714
+[#717]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/717
+
+### `@krassowski/completion-theme 3.2.0` (2021-12-12)
+
+- features:
+  - add `details-below` layout allowing to change the completer arrangement ([#698])
+
+### `jupyter-lsp 1.5.1` (2021-12-12)
+
+- documentation improvements:
+  - document troubleshooting steps for `texlab` server([#702])
+- maintenance and upkeep:
+  - migrate test configuration to `ServerApp` as needed ([#713])
+  - address deprecation warnings ([#713])
+
+[#702]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/702
+[#713]: https://github.com/jupyter-lsp/jupyterlab-lsp/pull/713
+
 ### `@krassowski/jupyterlab-lsp 3.9.1` (2021-10-24)
 
 - bug fixes:
@@ -11,7 +102,7 @@
 
 - features:
   - add support for new `typescript-language-server` replacing `javascript-typescript-langserver`;
-    despite the name both packages provide support for all four: JavaScrip, JSX, TypeScript and TSX;
+    despite the name both packages provide support for all four: JavaScript, JSX, TypeScript and TSX;
     the old `javascript-typescript-langserver` can still be used, but it is no longer maintained
     and we will not be supported, and specs may be removed in the next major release ([#697]).