Merge branch 'master' into tcp_mode

# Conflicts:
#	python_packages/jupyter_lsp/jupyter_lsp/connection.py
#	python_packages/jupyter_lsp/jupyter_lsp/manager.py

Author: FlyingSamson

.github/workflows/job.test.yml

@@ -228,8 +228,8 @@ jobs:
         include:
           # if using 3.7, use newer node, etc...
           - python: '3.7'
-            # Node 12 end-of-life: April 2022
-            nodejs: '>=12,<13.0.0.a0'
+            # Node 14 end-of-life: April 2023
+            nodejs: '>=14,<15.0.0.a0'
             r: '<4'
             lab: '>=3.1.0,<3.2'
           - python: '3.10'

CONTRIBUTING.md

@@ -31,7 +31,7 @@ Thank you for all your contributions :heart:
 
 Development requires, at a minimum:
 
-- `nodejs >=12,!=13,!=15,<17`
+- `nodejs >=14,!=15,<17`
 - `python >=3.7,<3.11.0a0`
   - Python 3.7 and 3.10 are fully tested on CI
   - Python 3.7 to 3.10 and PyPy 3 are verified to at least install and import

README.md

@@ -128,7 +128,6 @@ Use of a python `virtualenv` or a conda env is also recommended.
    R ([languageserver](https://github.com/REditorSupport/languageserver)) servers:
 
    ```bash
-   # note: you may want to use our fork of python-language-server instead (see below)
    pip install 'python-lsp-server[all]'
    R -e 'install.packages("languageserver")'
    ```
@@ -164,8 +163,6 @@ Use of a python `virtualenv` or a conda env is also recommended.
 
    or permanently by setting `c.Completer.use_jedi = False` in your
    [`ipython_config.py` file](https://ipython.readthedocs.io/en/stable/config/intro.html?highlight=ipython_config.py#systemwide-configuration).
-   You will also benefit from using experimental version of python-language-server
-   as described in the Note 2 (above).
 
 1. (Optional, Linux/OSX-only) to enable opening files outside of the root
    directory (the place where you start JupyterLab), create `.lsp_symlink` and

atest/00_Smoke.robot

@@ -3,6 +3,7 @@ Resource        Keywords.resource
 
 Suite Setup     Set Screenshot Directory    ${SCREENSHOTS DIR}${/}smoke
 
+
 *** Test Cases ***
 Lab Version
     Capture Page Screenshot    00-smoke.png

atest/01_Editor.robot

@@ -6,6 +6,7 @@ Suite Setup     Setup Suite For Screenshots    editor
 
 Force Tags      ui:editor    aspect:ls:features
 
+
 *** Test Cases ***
 Bash
     Editor Shows Features for Language    Bash    example.sh    Diagnostics=Failed to parse expression
@@ -54,8 +55,13 @@ Markdown
 
 Python (pylsp)
     ${def} =    Set Variable    xpath:(//span[contains(@class, 'cm-variable')][contains(text(), 'fib')])[last()]
-    Editor Shows Features for Server    pylsp    Python    example.py    Diagnostics=undefined name 'result' (pyflakes)
-    ...    Jump to Definition=${def}    Rename=${def}
+    Editor Shows Features for Server
+    ...    pylsp
+    ...    Python
+    ...    example.py
+    ...    Diagnostics=undefined name 'result' (pyflakes)
+    ...    Jump to Definition=${def}
+    ...    Rename=${def}
 
 Python (pyright)
     ${def} =    Set Variable    xpath:(//span[contains(@class, 'cm-variable')][contains(text(), 'fib')])[last()]
@@ -69,7 +75,8 @@ R
 
 Robot Framework
     [Tags]    gh:332
-    ${def} =    Set Variable    xpath:(//span[contains(@class, 'cm-keyword')][contains(text(), 'Special Log')])[last()]
+    ${def} =    Set Variable
+    ...    xpath:(//span[contains(@class, 'cm-keyword')][contains(text(), 'Special Log')])[last()]
     Editor Shows Features for Language    Robot Framework    example.robot    Diagnostics=Undefined keyword
     ...    Jump to Definition=${def}
 
@@ -95,6 +102,7 @@ SQL
 YAML
     Editor Shows Features for Language    YAML    example.yaml    Diagnostics=Map keys must be unique
 
+
 *** Keywords ***
 Editor Shows Features for Server
     [Arguments]    ${server}    ${Language}    ${file}    &{features}
@@ -138,7 +146,7 @@ Editor Content Changed
     [Arguments]    ${old_content}
     ${new_content} =    Get Editor Content
     Should Not Be Equal    ${old_content}    ${new_content}
-    [Return]    ${new_content}
+    RETURN    ${new_content}
 
 Editor Should Rename
     [Arguments]    ${symbol}

atest/02_Settings.robot

@@ -3,6 +3,7 @@ Resource        Keywords.resource
 
 Suite Setup     Setup Suite For Screenshots    settings
 
+
 *** Test Cases ***
 Settings
     Open in Advanced Settings    ${LSP PLUGIN ID}

atest/03_Notebook.robot

@@ -4,6 +4,7 @@ Resource        Keywords.resource
 Suite Setup     Setup Suite For Screenshots    notebook
 Test Setup      Try to Close All Tabs
 
+
 *** Test Cases ***
 Python
     [Setup]    Setup Notebook    Python    Python.ipynb
@@ -101,6 +102,7 @@ Adding Text To Cells After Kernel Restart
     Wait Until Keyword Succeeds    3x    1s    File Content Should Be Equal    ${virtual_path}    \n\n\ntext\n
     [Teardown]    Clean Up After Working With File    Empty.ipynb
 
+
 *** Keywords ***
 File Content Should Be Equal
     [Arguments]    ${file}    ${text}

atest/04_Interface/BackendFailure.robot

@@ -4,10 +4,12 @@ Resource            ../Keywords.resource
 Suite Setup         Setup Server and Browser    server_extension_enabled=${False}
 Suite Teardown      Setup Server and Browser    server_extension_enabled=${True}
 
+
 *** Variables ***
 ${STATUSBAR}    css:div.lsp-statusbar-item
 ${POPOVER}      css:.lsp-popover
 
+
 *** Test Cases ***
 Handles Server Extension Failure
     Setup Notebook    Python    Python.ipynb    wait=${False}

atest/04_Interface/DiagnosticsPanel.robot

@@ -7,6 +7,7 @@ Test Teardown       Clean Up
 
 Force Tags          ui:notebook    aspect:ls:features
 
+
 *** Variables ***
 ${DIAGNOSTIC MESSAGE R}     Closing curly-braces should always be on their own line
 ${DIAGNOSTIC MESSAGE}       trailing whitespace
@@ -15,6 +16,7 @@ ${EXPECTED_COUNT}           4
 ${MENU COLUMNS}             xpath://div[contains(@class, 'lm-Menu-itemLabel')][contains(text(), "columns")]
 ${R CELL}                   %%R\n{}
 
+
 *** Test Cases ***
 Diagnostics Panel Opens
     Capture Page Screenshot    03-panel-opens.png
@@ -121,6 +123,7 @@ Diagnostics Panel Works After Removing Foreign Document
     Wait Until Keyword Succeeds    10 x    1s    Element Should Not Contain    ${DIAGNOSTICS PANEL}
     ...    ${DIAGNOSTIC MESSAGE R}
 
+
 *** Keywords ***
 Open Context Menu Over W291
     Click Element    css:.lsp-diagnostics-listing th[data-id="Code"]

atest/04_Interface/Statusbar.robot

@@ -3,12 +3,14 @@ Resource        ../Keywords.resource
 
 Suite Setup     Setup Suite For Screenshots    statusbar
 
+
 *** Variables ***
 ${STATUSBAR}        css:div.lsp-statusbar-item
 ${DIAGNOSTIC}       W291 trailing whitespace (pycodestyle)
 ${POPOVER}          css:.lsp-popover
 ${HELP_BUTTON}      css:.lsp-popover .lsp-help-button
 
+
 *** Test Cases ***
 Statusbar Popup Opens
     Setup Notebook    Python    Python.ipynb
@@ -68,6 +70,7 @@ Status Changes Correctly Between Editors
     Wait Until Element Contains    ${STATUSBAR}    Initialized (additional servers needed)    timeout=60s
     [Teardown]    Clean Up After Working With File    example.plain
 
+
 *** Keywords ***
 Switch To Tab
     [Arguments]    ${file}