Skip to content

Commit 800a426

Browse files
committed
Workaround breaking change in JupyterLab 3.1
1 parent ed835f8 commit 800a426

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

packages/jupyterlab-lsp/src/adapters/adapter.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,15 @@ export abstract class WidgetAdapter<T extends IDocumentWidget> {
278278
return;
279279
}
280280

281-
if (state === 'completed') {
281+
// TODO: remove workaround no later than with 3.2 release of JupyterLab
282+
// workaround for https://github.com/jupyterlab/jupyterlab/issues/10721
283+
// while already reverted in https://github.com/jupyterlab/jupyterlab/pull/10741,
284+
// it was not released yet and many users will continue to run 3.1.0 and 3.1.1
285+
// so lets workaround it for now
286+
// @ts-ignore
287+
const completedManually = state === 'completed manually';
288+
289+
if (state === 'completed' || completedManually) {
282290
// note: must only be send to the appropriate connections as
283291
// some servers (Julia) break if they receive save notification
284292
// for a document that was not opened before, see:

0 commit comments

Comments
 (0)