finished using puppeteer for memory benchmark

Author: krausest

README.md

@@ -221,6 +221,8 @@ After that you can check all results in [http://localhost:8080/webdriver-ts/tabl
 - You can select multiple frameworks and benchmarks for running with prefixes like in the following example in the webdriver-ts directory:
   `npm run bench -- --benchmark 01_ 02_ --framework keyed/vanillajs keyed/react-hooks`
   runs the test for all frameworks that contain either angular or bob, which means all angular versions and bobril and all benchmarks whose id contain 01* or 02*
+- The memory benchmarks assume certain paths for the chrome installation. If it doesn't fit use
+  `npm run bench -- --chromeBinary /usr/bin/google-chrome`
 - If you can't get one framework to compile or run, just move it out of the frameworks directory and re-run
 - One can check whether an implementation is keyed or non-keyed via `npm run isKeyed` in the webdriver-ts directory. You can limit which frameworks to check in the same way as the webdriver test runner like e.g. `npm run isKeyed keyed/svelte`. The program will report an error if a benchmark implementation is incorrectly classified.
 

package.json

@@ -12,7 +12,7 @@
     "results": "cd webdriver-ts && npm run results",
     "bench-all": "cd webdriver-ts && npm run bench && npm run results",
     "selenium": "cd webdriver-ts && npm run bench && npm run results",
-    "install-webdriver-ts": "cd webdriver-ts && npm install",
+    "install-webdriver-ts": "cd webdriver-ts && npm install && npm run compile",
     "install-webdriver-ts-results": "cd webdriver-ts-results && npm install",
     "install-local": "npm run install-webdriver-ts && npm run install-webdriver-ts-results",
     "docker-build-image": "docker build -t js-framework-benchmark-ubuntu -f Dockerfile .",

webdriver-ts-results/src/results.ts

@@ -8,8 +8,6 @@ const MemResultsTable = ({data, currentSortKey, sortBy}: {data: ResultTableData;
   return (resultsMEM.results.length===0 ? null :
         (<div>
           <h3>Memory allocation in MBs ± 95% confidence interval</h3>
-          <p>Please note that currently issue <a href="https://github.com/krausest/js-framework-benchmark/issues/916">#916</a> causes wrong values for some frameworks. 
-          </p>
           <table className='results'>
             <thead>
               <tr>

webdriver-ts-results/src/tables/MemResultsTable.tsx

@@ -5,7 +5,9 @@
   "main": "index.js",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1",
-    "bench": "cross-env LANG=\"en_US.UTF-8\" ts-node src/benchmarkRunner.ts",
+    "tsbench": "cross-env LANG=\"en_US.UTF-8\" ts-node src/benchmarkRunner.ts",
+    "bench": "cross-env LANG=\"en_US.UTF-8\" node dist/benchmarkRunner.js",
+    "compile": "tsc",
     "results": "ts-node src/createResultJS.ts && cd .. && cd webdriver-ts-results && npm run build-prod",
     "index": "ts-node src/createIndex.ts",
     "isKeyed": "cross-env LANG=\"en_US.UTF-8\" ts-node src/isKeyed.ts"

webdriver-ts-results/table.html

@@ -14,7 +14,7 @@ function forkAndCallBenchmark(
 ): Promise<ErrorAndWarning> {
   return new Promise((resolve, reject) => {
     const forked = fork(
-      benchmark.type == BenchmarkType.MEM ? "src/forkedBenchmarkRunnerPuppeteer.ts" : "src/forkedBenchmarkRunnerWebdriver.ts"
+      benchmark.type == BenchmarkType.MEM ? "dist/forkedBenchmarkRunnerPuppeteer.js" : "dist/forkedBenchmarkRunnerWebdriver.js"
     );
     if (config.LOG_DETAILS) console.log("FORKING:  forked child process");
     forked.send({
@@ -185,12 +185,13 @@ async function runBench(runFrameworks: FrameworkData[], benchmarkNames: string[]
 
 let args: any = yargs(process.argv)
   .usage(
-    "$0 [--framework Framework1 Framework2 ...] [--benchmark Benchmark1 Benchmark2 ...] [--count n] [--exitOnError] \n or: $0 [directory1] [directory2] .. [directory3] \n or: $0 installed"
+    "$0 [--framework Framework1 Framework2 ...] [--benchmark Benchmark1 Benchmark2 ...] [--chromeBinary path] \n or: $0 [directory1] [directory2] .. [directory3]"
   )
   .help("help")
   .default("headless", false)
   .array("framework")
-  .array("benchmark").argv;
+  .array("benchmark")
+  .string("chromeBinary").argv;
 
 let allArgs = args._.length <= 2 ? [] : args._.slice(2, args._.length);
 let frameworkArgument = !args.framework ? allArgs : args.framework;

webdriver-ts/package.json

@@ -3,15 +3,7 @@
 import { Browser, Page } from "puppeteer-core";
 import { BenchmarkInfo, BenchmarkType } from "./benchmarksGeneric";
 import { config, FrameworkData } from "./common";
-import {
-  clickElementById,
-  clickElementByXPath,
-  waitForClassContained,
-  waitForElementLocatedById,
-  waitForElementLocatedByXpath,
-  waitForElementNotLocatedByXPath,
-  waitForTextContains,
-} from "./puppeteerAccess";
+import { clickElementById, waitForElement, waitForElementNotLocatedByXPath, waitForTextContains } from "./puppeteerAccess";
 
 const BENCHMARK_21 = "21_ready-memory";
 const BENCHMARK_22 = "22_run-memory";
@@ -20,8 +12,6 @@ const BENCHMARK_24 = "24_run5-memory";
 const BENCHMARK_25 = "25_run-clear-memory";
 const BENCHMARK_31 = "31_startup-ci";
 
-type TBenchmarkID = typeof BENCHMARK_21 | typeof BENCHMARK_22 | typeof BENCHMARK_23 | typeof BENCHMARK_25 | typeof BENCHMARK_31;
-
 export abstract class BenchmarkPuppeteer {
   id: string;
   type: BenchmarkType;
@@ -63,15 +53,10 @@ const benchReadyMemory = new (class extends BenchmarkPuppeteer {
     });
   }
   async init(page: Page) {
-    await waitForElementLocatedById(page, "add", true);
-  }
-  async run(page: Page) {
-    await waitForElementNotLocatedByXPath(page, "//tbody/tr[1]", false);
-  }
-  async after(page: Page, framework: FrameworkData) {
-    await clickElementById(page, "run", true);
-    await waitForElementLocatedByXpath(page, "//tbody/tr[1]/td[2]/a", false);
+    await waitForElement(page, "pierce/#run");
   }
+  async run(page: Page) {}
+  async after(page: Page, framework: FrameworkData) {}
 })();
 
 const benchRunMemory = new (class extends BenchmarkPuppeteer {
@@ -85,11 +70,11 @@ const benchRunMemory = new (class extends BenchmarkPuppeteer {
     });
   }
   async init(page: Page) {
-    await waitForElementLocatedById(page, "add", true);
+    await waitForElement(page, "pierce/#run");
   }
   async run(page: Page) {
-    await clickElementById(page, "run", true);
-    await waitForElementLocatedByXpath(page, "//tbody/tr[1]/td[2]/a", false);
+    await clickElementById(page, "pierce/#run");
+    await waitForElement(page, "pierce/tbody>tr:nth-of-type(1)>td:nth-of-type(2)>a");
   }
 })();
 
@@ -104,13 +89,13 @@ const benchUpdate5Memory = new (class extends BenchmarkPuppeteer {
     });
   }
   async init(page: Page) {
-    await waitForElementLocatedById(page, "add", true);
+    await waitForElement(page, "pierce/#run");
   }
   async run(page: Page) {
-    await clickElementById(page, "run", true);
+    await clickElementById(page, "pierce/#run");
     for (let i = 0; i < 5; i++) {
-      await clickElementById(page, "update", true);
-      await waitForTextContains(page, "//tbody/tr[1]/td[2]/a", " !!!".repeat(i), false);
+      await clickElementById(page, "pierce/#update");
+      await waitForTextContains(page, "pierce/tbody>tr:nth-of-type(1)>td:nth-of-type(2)>a", " !!!".repeat(i));
     }
   }
 })();
@@ -126,12 +111,12 @@ const benchReplace5Memory = new (class extends BenchmarkPuppeteer {
     });
   }
   async init(page: Page) {
-    await waitForElementLocatedById(page, "add", true);
+    await waitForElement(page, "pierce/#run");
   }
   async run(page: Page) {
     for (let i = 0; i < 5; i++) {
-      await clickElementById(page, "run", true);
-      await waitForTextContains(page, "//tbody/tr[1000]/td[1]", (1000 * (i + 1)).toFixed(), false);
+      await clickElementById(page, "pierce/#run");
+      await waitForTextContains(page, "pierce/tbody>tr:nth-of-type(1000)>td:nth-of-type(1)", (1000 * (i + 1)).toFixed());
     }
   }
 })();
@@ -147,14 +132,14 @@ const benchCreateClear5Memory = new (class extends BenchmarkPuppeteer {
     });
   }
   async init(page: Page) {
-    await waitForElementLocatedById(page, "add", true);
+    await waitForElement(page, "pierce/#run");
   }
   async run(page: Page) {
     for (let i = 0; i < 5; i++) {
-      await clickElementById(page, "run", true);
-      await waitForTextContains(page, "//tbody/tr[1000]/td[1]", (1000 * (i + 1)).toFixed(), false);
-      await clickElementById(page, "clear", true);
-      await waitForElementNotLocatedByXPath(page, "//tbody/tr[1000]/td[1]", false);
+      await clickElementById(page, "pierce/#run");
+      await waitForTextContains(page, "pierce/tbody>tr:nth-of-type(1000)>td:nth-of-type(1)", (1000 * (i + 1)).toFixed());
+      await clickElementById(page, "pierce/#clear");
+      await waitForElementNotLocatedByXPath(page, "pierce/tbody>tr:nth-of-type(1000)>td:nth-of-type(1)");
     }
   }
 })();