Use new headless mode

Author: krausest

webdriver-ts/src/forkedBenchmarkRunnerPlaywright.ts

@@ -190,13 +190,7 @@ async function runMemBenchmark(
       await wait(40);
       // let result = (await client.send('Performance.getMetrics')).metrics.filter((m) => m.name==='JSHeapUsedSize')[0].value / 1024 / 1024;
 
-      let result = 0;
-      if (benchmarkOptions.headless) {
-        console.log("performance.measureUserAgentSpecificMemory doesn't work for headless.");
-        result = (await client.send('Performance.getMetrics')).metrics.filter((m) => m.name==='JSHeapUsedSize')[0].value / 1024 / 1024;
-      } else {
-        result = (await page.evaluate("performance.measureUserAgentSpecificMemory()") as any).bytes / 1024 / 1024;
-      }
+      let result = (await page.evaluate("performance.measureUserAgentSpecificMemory()") as any).bytes / 1024 / 1024;
       console.log("afterBenchmark ");
       results.push(result);
       console.log(`memory result for ${framework.name} and ${benchmark.benchmarkInfo.id}: ${result}`);

webdriver-ts/src/forkedBenchmarkRunnerPuppeteer.ts

@@ -194,15 +194,7 @@ async function runMemBenchmark(
       await runBenchmark(page, benchmark, framework);
       await forceGC(page, client);
       await wait(40);
-      let result = 0;
-      if (benchmarkOptions.headless) {
-        console.log("performance.measureUserAgentSpecificMemory doesn't work for headless.");
-        let metrics = await page.metrics();
-        let result = metrics.JSHeapUsedSize / 1024.0 / 1024.0;
-    } else {
-        result = (await page.evaluate("performance.measureUserAgentSpecificMemory()") as any).bytes / 1024 / 1024;
-      }
-
+      let result = (await page.evaluate("performance.measureUserAgentSpecificMemory()") as any).bytes / 1024 / 1024;
       console.log("afterBenchmark");
 
       results.push(result);

webdriver-ts/src/playwrightAccess.ts

@@ -94,12 +94,11 @@ function browserPath(benchmarkOptions: BenchmarkDriverOptions) {
 }
 
 export async function startBrowser(benchmarkOptions: BenchmarkDriverOptions): Promise<Browser> {
-  const width = 1280;
-  const height = 800;
-
+  let args = ['--window-size=1000,800', '--js-flags=--expose-gc'];
+  if (benchmarkOptions.headless) args.push('--headless=chrome');
   const browser = await chromium.launch({
-    args: [`--window-size=${width},${height}`, '--js-flags=--expose-gc' ],
-    headless: benchmarkOptions.headless,
+    args,
+    headless: false,
     // executablePath: "/Applications/Google Chrome.app/Contents/MacOS/Google Chrome",
     executablePath: browserPath(benchmarkOptions),
   });

webdriver-ts/src/puppeteerAccess.ts

@@ -98,8 +98,11 @@ export async function startBrowser(benchmarkOptions: BenchmarkDriverOptions): Pr
   let window_width = width,
     window_height = height;
 
+  let args = [`--window-size=${window_width},${window_height}`,'--js-flags=--expose-gc' ];
+  if (benchmarkOptions.headless) args.push('--headless=chrome');
+
   const browser = await puppeteer.launch({
-    headless: benchmarkOptions.headless,
+    headless: false,
     executablePath: browserPath(benchmarkOptions),
     ignoreDefaultArgs: ["--enable-automation",  // 92/115
     "--disable-background-networking",
@@ -127,7 +130,7 @@ export async function startBrowser(benchmarkOptions: BenchmarkDriverOptions): Pr
     // "--enable-blink-features=IdleDetection",
     // // "--export-tagged-pdf"
   ],
-    args: [`--window-size=${window_width},${window_height}`,'--js-flags=--expose-gc' ],
+    args,
     dumpio: false,
     defaultViewport: {
       width,