results for chrome 114

Author: krausest

frameworks/keyed/blockdom/package.json

@@ -5,7 +5,8 @@
   "main": "dist/app.min.js",
   "js-framework-benchmark": {
     "frameworkVersionFromPackage": "blockdom",
-    "frameworkHomeURL": "https://github.com/ged-odoo/blockdom"
+    "frameworkHomeURL": "https://github.com/ged-odoo/blockdom",
+    "issues": [1261]
   },
   "scripts": {
     "build-dev": "rollup -c -w",

frameworks/keyed/million/package-lock.json

@@ -15,10 +15,10 @@ const App = (): JSX.Element => {
     return (
       <div>
         {disclaimer}
-        <p>The benchmark was run on a MacBook Pro 14 (32 GB RAM, 8/14 Cores, OSX 13.3), Chrome 113.0.5672.63 (arm64))
+        <p>The benchmark was run on a MacBook Pro 14 (32 GB RAM, 8/14 Cores, OSX 13.4), Chrome 114.0.5735.90 (arm64))
             using the puppeteer benchmark driver with reduced tracing.
         </p>
-         <SelectionBar/>
+         <SelectionBar showDurationSelection={false}/>
          <ResultTable type={FrameworkType.KEYED}/>
          <ResultTable type={FrameworkType.NON_KEYED}/>
 

webdriver-ts-results/src/App.tsx

@@ -20,22 +20,6 @@ export interface Framework {
 
 export enum Severity {Note, Error}
 
-interface Category {
-  id: number;
-  text: string;
-  issues: Array<number>;
-  severity: Severity;
-}
-
-export const categories: Category[] = [
-  {id:1, text:"[Note]: Manual DOM manipulations", issues: [772], severity: Severity.Note},
-  {id:2, text:"[Note]: View state on the model", issues: [800], severity: Severity.Note},
-  {id:3, text:"[Note]: Explicit requestAnimationFrame calls", issues: [796], severity: Severity.Note},
-  {id:4, text:"[Note]: Manual event delegation", issues: [801], severity: Severity.Note},
-  {id:5, text:"[Note]: Implementation uses runtime code generation", issues: [1139], severity: Severity.Note},
-  {id:6, text:"[Issue]: Errors in the implementation", issues: [634], severity: Severity.Error},
-]
-
 const DEFAULT_RESULTS_KEY = 'DEFAULT';
 
 interface IIssue {
@@ -52,6 +36,7 @@ export const knownIssues: IIssue[] = [
     {issue: 800, severity: Severity.Note, text:"[Note]: View state on the model", link: "https://github.com/krausest/js-framework-benchmark/issues/800"},
     {issue: 801, severity: Severity.Note, text:"[Note]: Implementation uses manual event delegation", link: "https://github.com/krausest/js-framework-benchmark/issues/801"},
     {issue: 1139, severity: Severity.Note, text:"[Note]: Implementation uses runtime code generation", link: "https://github.com/krausest/js-framework-benchmark/issues/1139"},
+    {issue: 1261, severity: Severity.Note, text:"[Note]: Manual caching of (v)dom nodes", link: "https://github.com/krausest/js-framework-benchmark/issues/1261"},
 ];
 
 export function findIssue(issueNumber: number): IIssue|undefined {
@@ -215,12 +200,7 @@ export class ResultTableData {
         this.selectedFameworks = new Set<Framework>();
 
         const allowedIssues = new Set<number>();
-        categories.forEach(c => {
-          if (selectedCategories.has(c.id)) {
-            for (const i of c.issues) { allowedIssues.add(i); }
-          }
-        });
-
+        knownIssues.forEach(i => allowedIssues.add(i.issue));
         console.log("ResultTableData", allowedIssues, selectedCategories);
 
         selectedFrameworksInDropdown.forEach(f => {

webdriver-ts-results/src/Common.ts

@@ -1,4 +1,4 @@
-import { Benchmark, BenchmarkType, convertToMap, DisplayMode, Framework, FrameworkType, RawResult, Result, ResultTableData, SORT_BY_GEOMMEAN_CPU, categories, Severity, ResultValues, CpuDurationMode } from "./Common"
+import { Benchmark, BenchmarkType, convertToMap, DisplayMode, Framework, FrameworkType, RawResult, Result, ResultTableData, SORT_BY_GEOMMEAN_CPU, Severity, ResultValues, CpuDurationMode, knownIssues } from "./Common"
 import { benchmarks as benchmark_orig, frameworks, results as rawResults } from './results';
 
 // Temporarily disable script bootup time
@@ -96,7 +96,7 @@ let preInitialState: State = {
     [FrameworkType.KEYED]: undefined,
     [FrameworkType.NON_KEYED]: undefined
   },
-  categories: new Set(categories.filter(c => c.severity != Severity.Error).map(c => c.id)),
+  categories: new Set(knownIssues.map(ki => ki.issue)),
   cpuDurationMode : CpuDurationMode.Total
 }
 
@@ -131,15 +131,6 @@ function extractState(state: any): Partial<State> {
   if (state.displayMode!==undefined) {
     t = { ...t, displayMode: state.displayMode };
   }
-  if (state.categories!==undefined) {
-    const newSelectedCategories = new Set<number>();
-    for (const f of state?.categories ?? []) {
-      for (const sc of categories) {
-        if (f === sc.id) newSelectedCategories.add(sc.id);
-      }
-    }
-    t = { ...t, categories: newSelectedCategories };
-  }
   return t;
 }
 
@@ -312,11 +303,6 @@ export const reducer = (state = initialState, action: Action): State => {
       const t = { ...state, categories };
       return { ...t, resultTables: updateResultTable(t) };
     }
-    case 'SELECT_ALL_CATEGORIES': {
-      const newCategories = (action.data.add) ? new Set(categories.map(c => c.id)) : new Set<number>();
-      const t = { ...state, categories: newCategories };
-      return { ...t, resultTables: updateResultTable(t) };
-    }
     default:
       return state;
   }