Skip to content

Commit 13b99ac

Browse files
committed
update results for chrome 105
1 parent 11058c0 commit 13b99ac

File tree

10 files changed

+3530
-3499
lines changed

10 files changed

+3530
-3499
lines changed

webdriver-ts-results/src/App.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const App = (): JSX.Element => {
1515
return (
1616
<div>
1717
{disclaimer}
18-
<p>The benchmark was run on a MaBook Air M1 (16 GB RAM, OSX 12.5), Chrome 104.0.5112.79 (arm64))
18+
<p>The benchmark was run on a MaBook Air M1 (16 GB RAM, OSX 12.5), Chrome 105.0.5195.102 (arm64))
1919
using the puppeteer benchmark driver with reduced tracing.
2020
</p>
2121
<SelectionBar/>

webdriver-ts-results/src/Common.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -343,13 +343,19 @@ export class ResultTableData {
343343
return result.mean;
344344
}
345345
}
346-
const min = benchmarkResults.reduce((min, result) => result===null ? min : Math.min(min, selectFn(result)), Number.POSITIVE_INFINITY);
346+
let min = Math.max(benchmarkResults.reduce((min, result) => result===null ? min : Math.min(min, selectFn(result)), Number.POSITIVE_INFINITY));
347+
// if (benchmark.type === BenchmarkType.CPU) {
348+
// min = Math.max(1000/60, min);
349+
// }
347350
return this.frameworks.map(f => {
348351
const result = this.results(benchmark, f);
349352
if (result === null) return null;
350353

351354
const value = selectFn(result);
352-
const factor = value/min;
355+
let factor = value/min;
356+
// if (benchmark.type === BenchmarkType.CPU) {
357+
// factor = Math.max(1, factor);
358+
// }
353359
const conficenceInterval = 1.959964 * (result.standardDeviation || 0) / Math.sqrt(result.values.length);
354360
const conficenceIntervalStr = benchmark.type === BenchmarkType.MEM ? null : conficenceInterval.toFixed(1);
355361
const formattedValue = formatEn.format(value);

webdriver-ts-results/src/results.ts

Lines changed: 3222 additions & 3222 deletions
Large diffs are not rendered by default.

webdriver-ts-results/table.html

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

webdriver-ts/package-lock.json

Lines changed: 276 additions & 252 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webdriver-ts/package.json

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -17,35 +17,35 @@
1717
"author": "",
1818
"license": "Apache-2.0",
1919
"devDependencies": {
20-
"@types/lodash": "4.14.182",
21-
"@types/node": "18.6.3",
20+
"@types/lodash": "4.14.184",
21+
"@types/node": "18.7.14",
2222
"@types/ramda": "^0.28.15",
23-
"@types/selenium-webdriver": "4.1.2",
24-
"@types/semver": "7.3.10",
23+
"@types/selenium-webdriver": "4.1.3",
24+
"@types/semver": "7.3.12",
2525
"@types/underscore": "^1.11.4",
26-
"@types/yargs": "17.0.10",
27-
"@typescript-eslint/eslint-plugin": "^5.32.0",
28-
"@typescript-eslint/parser": "^5.32.0",
29-
"dockerode": "^3.3.3",
30-
"eslint": "^8.21.0",
26+
"@types/yargs": "17.0.12",
27+
"@typescript-eslint/eslint-plugin": "^5.36.1",
28+
"@typescript-eslint/parser": "^5.36.1",
29+
"dockerode": "^3.3.4",
30+
"eslint": "^8.23.0",
3131
"rimraf": "^3.0.2",
3232
"ts-node": "10.9.1",
33-
"typescript": "4.7.4"
33+
"typescript": "4.8.2"
3434
},
3535
"dependencies": {
3636
"axios": "^0.27.2",
37-
"chromedriver": "^103.0.0",
37+
"chromedriver": "^105.0.0",
3838
"cross-env": "7.0.3",
3939
"dot": "1.1.3",
4040
"jstat": "1.9.5",
41-
"lighthouse": "9.6.5",
41+
"lighthouse": "9.6.7",
4242
"lodash": "4.17.21",
4343
"marky": "^1.2.5",
44-
"npm-check-updates": "16.0.5",
45-
"playwright": "^1.24.2",
46-
"puppeteer-core": "^15.5.0",
44+
"npm-check-updates": "16.0.6",
45+
"playwright": "^1.25.1",
46+
"puppeteer-core": "^17.1.0",
4747
"ramda": "^0.28.0",
48-
"selenium-webdriver": "4.3.1",
48+
"selenium-webdriver": "4.4.0",
4949
"semver": "7.3.7",
5050
"underscore": "^1.13.4",
5151
"yargs": "17.5.1"

webdriver-ts/results.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

webdriver-ts/src/benchmarksPuppeteer.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -249,6 +249,7 @@ export const benchUpdate5Memory = new (class extends MemBenchmarkPuppeteer {
249249
}
250250
async run(page: Page) {
251251
await clickElement(page, "pierce/#run");
252+
await checkElementExists(page, "pierce/tbody>tr:nth-of-type(1000)>td:nth-of-type(2)>a");
252253
for (let i = 0; i < 5; i++) {
253254
await clickElement(page, "pierce/#update");
254255
await checkElementContainsText(page, "pierce/tbody>tr:nth-of-type(1)>td:nth-of-type(2)>a", " !!!".repeat(i));

webdriver-ts/src/forkedBenchmarkRunnerPlaywright.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ async function runMemBenchmark(
170170
});
171171
}
172172

173-
await page.goto(`http://${benchmarkOptions.HOST}:${benchmarkOptions.port}/${framework.uri}/index.html`);
173+
await page.goto(`http://${benchmarkOptions.HOST}:${benchmarkOptions.port}/${framework.uri}/index.html`, {waitUntil: "networkidle"});
174174

175175
// await (driver as any).sendDevToolsCommand('Network.enable');
176176
// await (driver as any).sendDevToolsCommand('Network.emulateNetworkConditions', {

webdriver-ts/src/forkedBenchmarkRunnerPuppeteer.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ async function runCPUBenchmark(framework: FrameworkData, benchmark: CPUBenchmark
127127
// let m1 = await page.metrics();
128128
await runBenchmark(page, benchmark, framework);
129129

130-
await wait(10);
130+
await wait(40);
131131
await page.tracing.stop();
132132
// let m2 = await page.metrics();
133133
if (benchmark.benchmarkInfo.throttleCPU) {
@@ -181,8 +181,8 @@ async function runMemBenchmark(
181181
for (let i = 0; i < msg.args().length; ++i) console.log(`BROWSER: ${msg.args()[i]}`);
182182
});
183183
}
184-
185-
await page.goto(`http://${benchmarkOptions.HOST}:${benchmarkOptions.port}/${framework.uri}/index.html`);
184+
185+
await page.goto(`http://${benchmarkOptions.HOST}:${benchmarkOptions.port}/${framework.uri}/index.html`, {waitUntil: "networkidle0"});
186186

187187
// await (driver as any).sendDevToolsCommand('Network.enable');
188188
// await (driver as any).sendDevToolsCommand('Network.emulateNetworkConditions', {

0 commit comments

Comments
 (0)