Performance improvement

Author: nihil-pro

frameworks/keyed/preact-kr-observable/src/Main.jsx

@@ -1,8 +1,7 @@
-import { render, h } from "preact";
+import { render } from "preact";
 import { observer } from 'kr-observable/preact';
 import { Row } from './Row';
 import { rowsStore } from './RowsStore';
-import { Fragment } from "preact";
 
 const Button = ({ children, id, onClick }) => {
   return (
@@ -83,7 +82,5 @@ function Main() {
   );
 }
 
-if (typeof window !== "undefined") {
-  render(<Main />, document.getElementById('main'));
-}
+render(<Main />, document.getElementById('main'));
 

frameworks/keyed/preact-kr-observable/src/Row.jsx

@@ -6,10 +6,10 @@ export const Row = observer(function row({ data }) {
     <tr className={data.selected ? 'danger' : ''}>
       <td className="col-md-1">{data.id}</td>
       <td className="col-md-4">
-        <a id={data.id} onClick={rowsStore.select}>{data.label}</a>
+        <a id={data.id} onClick={() => rowsStore.select(data.id)}>{data.label}</a>
       </td>
       <td className="col-md-1">
-        <a onClick={rowsStore.delete}>
+        <a onClick={() => rowsStore.delete(data.id)}>
           <span
             id={data.id}
             className="glyphicon glyphicon-remove"
@@ -21,3 +21,4 @@ export const Row = observer(function row({ data }) {
     </tr>
   );
 });
+

frameworks/keyed/preact-kr-observable/src/RowsStore.js

@@ -5,8 +5,8 @@ export class RowsStore extends Observable {
   static shallow = new Set(['rows'])
   rows = [];
 
-  delete(e) {
-    const rowIndexToDelete = this.rows.findIndex((row) => row.id === +e.target.id);
+  delete(id) {
+    const rowIndexToDelete = this.rows.findIndex(row => row.id === id);
     this.rows.splice(rowIndexToDelete, 1);
   };
 
@@ -19,13 +19,14 @@ export class RowsStore extends Observable {
   };
 
   update() {
-    for (let i = 0; i < this.rows.length; i += 10) {
+    const length = this.rows.length;
+    for (let i = 0; i < length; i += 10) {
       this.rows[i].label += ' !!!';
     }
   };
 
-  select(e) {
-    this.rows.forEach(row => row.selected = row.id === +e.target.id)
+  select(id) {
+    this.rows.forEach(row => row.selected = row.id === id)
   };
 
   runLots() {
@@ -47,4 +48,5 @@ export class RowsStore extends Observable {
 }
 
 
-export const rowsStore = new RowsStore()
+
+export const rowsStore = new RowsStore()