Skip to content

Commit 1b84471

Browse files
committed
fix #1057
1 parent 68bd48e commit 1b84471

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

frameworks/keyed/glimmer-2/src/MyTable.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,9 @@ export default class MyTable extends Component {
2929
}
3030

3131
@action add(): void {
32-
this.data = add(this.id, this.data);
32+
const result = add(this.id, this.data);
33+
this.data = result.data;
34+
this.id = result.id;
3335
}
3436

3537
@action update(): void {

frameworks/keyed/glimmer-2/src/utils/benchmark-helpers.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,9 @@ export const buildData = (id, count = 1000): ItemsSnapshot => {
102102
return { data, id };
103103
};
104104

105-
export const add = (id, data): TodoItem[] => {
105+
export const add = (id, data): ItemsSnapshot => {
106106
const newData = buildData(id, 1000);
107-
return [...data, ...newData.data];
107+
return {data: [ ...data, ...newData.data], id: newData.id};
108108
};
109109

110110
export const run = (id): ItemsSnapshot => {

frameworks/keyed/glimmer/src/ui/components/Glimmer/component.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,9 @@ export default class Glimmer extends Component {
3232
if (isRendering(this)) {
3333
return;
3434
}
35-
this.data = add(this.id, this.data).data;
35+
const result = add(this.id, this.data);
36+
this.data = result.data;
37+
this.id = result.id;
3638
}
3739

3840
public update() {

0 commit comments

Comments
 (0)