Skip to content

Commit 1e15afa

Browse files
committed
upgrade Recoil to latest and React 18
1 parent 11058c0 commit 1e15afa

File tree

3 files changed

+60
-65
lines changed

3 files changed

+60
-65
lines changed

frameworks/keyed/react-recoil/package-lock.json

Lines changed: 39 additions & 43 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

frameworks/keyed/react-recoil/package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "js-framework-benchmark-react-recoil",
3-
"version": "1.0.0",
3+
"version": "1.1.0",
44
"description": "React Recoil demo",
55
"main": "index.js",
66
"js-framework-benchmark": {
@@ -31,8 +31,8 @@
3131
"webpack-cli": "3.3.4"
3232
},
3333
"dependencies": {
34-
"react": "17.0.1",
35-
"react-dom": "17.0.1",
36-
"recoil": "0.2.0"
34+
"react": "18.2.0",
35+
"react-dom": "18.2.0",
36+
"recoil": "0.7.5"
3737
}
38-
}
38+
}

frameworks/keyed/react-recoil/src/main.jsx

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
useSetRecoilState,
77
useRecoilValue,
88
} from "recoil";
9-
import { render } from "react-dom";
9+
import { createRoot } from 'react-dom/client';
1010

1111
const random = (max) => Math.round(Math.random() * 1000) % max;
1212

@@ -25,9 +25,8 @@ const buildData = (count) => {
2525
for (let i = 0; i < count; i++) {
2626
data[i] = {
2727
id: nextId++,
28-
label: `${A[random(A.length)]} ${C[random(C.length)]} ${
29-
N[random(N.length)]
30-
}`,
28+
label: `${A[random(A.length)]} ${C[random(C.length)]} ${N[random(N.length)]
29+
}`,
3130
};
3231
}
3332

@@ -138,15 +137,15 @@ const Jumbotron = memo(
138137
setAppState(({ data, selected }) =>
139138
data.length > 998
140139
? {
141-
data: [
142-
data[0],
143-
data[998],
144-
...data.slice(2, 998),
145-
data[1],
146-
data[999],
147-
],
148-
selected,
149-
}
140+
data: [
141+
data[0],
142+
data[998],
143+
...data.slice(2, 998),
144+
data[1],
145+
data[999],
146+
],
147+
selected,
148+
}
150149
: state
151150
);
152151
}, [setAppState]);
@@ -203,9 +202,9 @@ const Main = () => {
203202
);
204203
};
205204

206-
render(
205+
const root = createRoot(document.getElementById('main'));
206+
root.render(
207207
<RecoilRoot>
208208
<Main />
209-
</RecoilRoot>,
210-
document.getElementById("main")
211-
);
209+
</RecoilRoot>
210+
);

0 commit comments

Comments
 (0)