Skip to content

Commit 20957eb

Browse files
committed
cleaner solution to #1688
1 parent ac8bb48 commit 20957eb

File tree

2 files changed

+1
-34
lines changed

2 files changed

+1
-34
lines changed

webdriver-ts/Preferences

Lines changed: 0 additions & 24 deletions
This file was deleted.

webdriver-ts/src/puppeteerAccess.ts

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -111,15 +111,6 @@ export async function startBrowser(benchmarkOptions: BenchmarkOptions): Promise<
111111
const window_width = width,
112112
window_height = height;
113113

114-
// delete the folder './chrome_profile' if it exists see https://github.com/krausest/js-framework-benchmark/issues/1688
115-
const dir = "chrome_profile";
116-
if (fs.existsSync(dir)) {
117-
fs.rmSync(dir, { recursive: true });
118-
}
119-
fs.mkdirSync(dir);
120-
fs.mkdirSync(path.join(dir,"Default"));
121-
fs.copyFileSync("Preferences", path.join(dir, "Default","Preferences"));
122-
123114
const args = [
124115
`--window-size=${window_width},${window_height}`,
125116
"--js-flags=--expose-gc", // needed for gc() function
@@ -130,7 +121,7 @@ export async function startBrowser(benchmarkOptions: BenchmarkOptions): Promise<
130121
"--disable-extensions",
131122
"--disable-features=Translate", // avoid translation popups
132123
"--disable-features=PrivacySandboxSettings4", // avoid privacy popup
133-
"--user-data-dir=./chrome_profile"
124+
"--disable-features=IPH_SidePanelGenericMenuFeature" // bookmark popup see https://github.com/krausest/js-framework-benchmark/issues/1688
134125
];
135126
if (benchmarkOptions.headless) args.push("--headless=new");
136127

0 commit comments

Comments
 (0)