Skip to content

Commit 2d3ae48

Browse files
Tweaked benchmark to use the selector in observable form
1 parent f3d7746 commit 2d3ae48

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

frameworks/keyed/voby/src/main.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,8 @@ const Button = ({ id, text, onClick }: { id: string | number, text: string, onCl
110110
</div>
111111
);
112112

113-
const Row = template (({ id, label, className, onSelect, onRemove }: { id: FunctionMaybe<string | number>, label: FunctionMaybe<string>, className: FunctionMaybe<string>, onSelect: ObservableMaybe<(( event: MouseEvent ) => any)>, onRemove: ObservableMaybe<(( event: MouseEvent ) => any)> }): JSX.Element => (
114-
<tr className={className}>
113+
const Row = template (({ id, label, className, onSelect, onRemove }: { id: FunctionMaybe<string | number>, label: FunctionMaybe<string>, className: FunctionMaybe<Record<string, FunctionMaybe<boolean>>>, onSelect: ObservableMaybe<(( event: MouseEvent ) => any)>, onRemove: ObservableMaybe<(( event: MouseEvent ) => any)> }): JSX.Element => (
114+
<tr class={className}>
115115
<td class="col-md-1">{id}</td>
116116
<td class="col-md-4">
117117
<a onClick={onSelect}>{label}</a>
@@ -153,7 +153,8 @@ const App = (): JSX.Element => {
153153
<For values={$data}>
154154
{( datum: IDatum ) => {
155155
const {id, label} = datum;
156-
const className = () => isSelected ( id ) ? 'danger' : '';
156+
const selected = isSelected ( id, { observable: true } );
157+
const className = { danger: selected };
157158
const onSelect = select.bind ( undefined, id );
158159
const onRemove = remove.bind ( undefined, id );
159160
const props = {id, label, className, onSelect, onRemove};

0 commit comments

Comments
 (0)