Skip to content

Commit 2dc6575

Browse files
nihil-pronihil-pro
authored andcommitted
Performance improvement
1 parent f82b17d commit 2dc6575

File tree

6 files changed

+24
-34
lines changed

6 files changed

+24
-34
lines changed

frameworks/keyed/preact-kr-observable/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"url": "https://github.com/krausest/js-framework-benchmark.git"
2020
},
2121
"dependencies": {
22-
"kr-observable": "1.0.37",
22+
"kr-observable": "1.0.39",
2323
"preact": "^10.25.0",
2424
"react": "18.2.0",
2525
"react-dom": "18.2.0"

frameworks/keyed/preact-kr-observable/src/RowsStore.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { Observable } from 'kr-observable';
22
import { buildData } from './data';
33

44
export class RowsStore extends Observable {
5+
static shallow = ['rows']
56
rows = [];
67

78
delete(e) {

frameworks/keyed/react-kr-observable/package-lock.json

Lines changed: 14 additions & 26 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

frameworks/keyed/react-kr-observable/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@
1919
"url": "https://github.com/krausest/js-framework-benchmark.git"
2020
},
2121
"dependencies": {
22-
"kr-observable": "1.0.37",
23-
"react": "18.2.0",
24-
"react-dom": "18.2.0"
22+
"kr-observable": "1.0.39",
23+
"react": "18.3.1",
24+
"react-dom": "18.3.1"
2525
},
2626
"devDependencies": {
2727
"@babel/core": "7.21.8",

frameworks/keyed/react-kr-observable/src/RowsStore.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { Observable } from 'kr-observable';
22
import { buildData } from './data';
33

44
export class RowsStore extends Observable {
5+
static shallow = ['rows']
56
rows = [];
67

78
delete(e) {
@@ -46,4 +47,6 @@ export class RowsStore extends Observable {
4647
};
4748
}
4849

50+
51+
4952
export const rowsStore = new RowsStore()

frameworks/keyed/react-kr-observable/src/data.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,11 @@ const random = (max) => Math.round(Math.random() * 1000) % max;
6565
export const buildData = (count) => {
6666
const data = [];
6767
for (let i = 0; i < count; i++) {
68-
const d = {
68+
data.push(makeObservable({
6969
id: id++,
7070
label: `${adjectives[random(adjectives.length)]} ${colours[random(colours.length)]} ${nouns[random(nouns.length)]}`,
7171
selected: false
72-
}
73-
74-
data.push(makeObservable(d, ['id']))
72+
}, ['id']))
7573
}
7674
return data;
7775
};

0 commit comments

Comments
 (0)