Skip to content

Commit 3f256f0

Browse files
committed
Use Mimbl 0.10.4.
1 parent 0934852 commit 3f256f0

File tree

5 files changed

+29
-28
lines changed

5 files changed

+29
-28
lines changed

frameworks/keyed/mimbl/package-lock.json

Lines changed: 9 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

frameworks/keyed/mimbl/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "js-framework-benchmark-keyed-mimbl",
3-
"version": "0.10.3",
3+
"version": "0.10.4",
44
"description": "Benchmark for Mimbl framework (keyed)",
55
"js-framework-benchmark": {
66
"frameworkVersionFromPackage": "mimbl",
@@ -28,6 +28,6 @@
2828
"webpack-cli": "^5.0.1"
2929
},
3030
"dependencies": {
31-
"mimbl": "^0.10.3"
31+
"mimbl": "^0.10.4"
3232
}
3333
}

frameworks/keyed/mimbl/src/Main.tsx

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -78,17 +78,17 @@ class Main extends mim.Component
7878
</div>
7979
</div>
8080
<table class="table table-hover table-striped test-data">
81-
<tbody vnref={this.vnTBody} updateStrategy={{disableKeyedNodeRecycling: true}}>
82-
{this.renderTBody}
83-
</tbody>
81+
{this.renderTBody}
8482
</table>
8583
<span class="preloadicon glyphicon glyphicon-remove" aria-hidden="true"></span>
8684
</div>);
8785
}
8886

8987
private renderTBody(): any
9088
{
91-
return this.renderRows(this.rows);
89+
return <tbody vnref={this.vnTBody} updateStrategy={{disableKeyedNodeRecycling: true}}>
90+
{this.renderRows(this.rows)}
91+
</tbody>
9292
}
9393

9494
private renderRows(rows: Row[]): any
@@ -127,11 +127,12 @@ class Main extends mim.Component
127127

128128
private onUpdateEvery10th()
129129
{
130-
if (!this.rows)
130+
let len = this.rows?.length
131+
if (!len)
131132
return;
132133

133134
let row: Row;
134-
for (let i = 0; i < this.rows.length; i += 10)
135+
for (let i = 0; i < len; i += 10)
135136
{
136137
row = this.rows[i];
137138
row.labelTrigger.set( row.label += " !!!")

frameworks/non-keyed/mimbl/package-lock.json

Lines changed: 9 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

frameworks/non-keyed/mimbl/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "js-framework-benchmark-non-keyed-mimbl",
3-
"version": "0.10.3",
3+
"version": "0.10.4",
44
"description": "Benchmark for Mimbl framework (non-keyed)",
55
"js-framework-benchmark": {
66
"frameworkVersionFromPackage": "mimbl",
@@ -28,6 +28,6 @@
2828
"webpack-cli": "^5.0.1"
2929
},
3030
"dependencies": {
31-
"mimbl": "^0.10.3"
31+
"mimbl": "^0.10.4"
3232
}
3333
}

0 commit comments

Comments
 (0)