Skip to content

Commit 47e5d05

Browse files
authored
Merge branch 'master' into refactor-webdriver
2 parents be8b2ed + cb9e66e commit 47e5d05

File tree

165 files changed

+44125
-10190
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

165 files changed

+44125
-10190
lines changed

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,11 @@ results might be for mixed browser versions, number of runs per benchmark may va
4646

4747
## Keyed vs non-keyed frameworks
4848

49-
Some frameworks like react, vue.js or angular allow to create a 1:1-relationship between a data item and a DOM node by assigning a “key” attribute (or for angular specifying “trackBy” in *ngFor). If you use some identifier of the data as the key you get the “keyed” mode. Any update to the data will update the associated DOM node. If you reorder the list, the DOM nodes will be reordered accordingly.
49+
Some frameworks like React, Vue.js or Angular, allow you to create a 1:1 relationship between a data item and a DOM node by assigning a “key” attribute (or for Angular, specifying “trackBy” in *ngFor). If you use some identifier of the data as the key, you get the “keyed” mode. Any update to the data will update the associated DOM node. If you reorder the list, the DOM nodes will be reordered accordingly.
5050

51-
The other mode is “non-keyed” and this is what e.g. vue.js uses by default for lists. In this mode a change to the data items can modify DOM nodes that were associated with other data before. This can be more performant, since costly DOM operations can be avoided (e.g. first removing old nodes, and the adding new nodes) and the existing DOM nodes are updated to display the new data. For react and angular using the item index as the key uses “non-keyed” mode for those frameworks.
51+
The other mode is “non-keyed” and this is what e.g. vue.js uses by default for lists. In this mode, a change to the data items can modify DOM nodes that were associated with other data before. This can be more performant, since costly DOM operations can be avoided (e.g. first removing old nodes and then adding new nodes) and the existing DOM nodes are updated to display the new data. For React and Angular, using the item index as the key uses “non-keyed” mode for those frameworks.
5252

53-
Depending on your requirements the “non-keyed” mode can be a performance gain or can cause severe problems so one must choose carefully the mode and check that the framework supports that mode.
53+
Depending on your requirements, the “non-keyed” mode can be a performance gain or can cause severe problems, so one must carefully choose the mode and check that the framework supports that mode.
5454

5555
Read more here: [https://www.stefankrause.net/wp/?p=342](https://www.stefankrause.net/wp/?p=342)
5656

@@ -72,7 +72,7 @@ v20.8.0
7272
```
7373

7474
## 1.2 Downloading the pre-built binaries and starting the server
75-
Builiding all frameworks can be challenging. There's a new way that allows to skip that and just run the benchmark without builiding all implementationss.
75+
building all frameworks can be challenging. There's a new way that allows to skip that and just run the benchmark without builiding all implementations.
7676

7777

7878
Start with checking out a tagged release like that. Pick the release that you want (e.g. chrome 100):
@@ -106,13 +106,13 @@ npm run results
106106
Open js-framework-benchmark/webdriver-ts-results/table.html in a browser and take a look at the results. You can open the result table with the link [http://localhost:8080/webdriver-ts-results/table.html](http://localhost:8080/webdriver-ts-results/table.html)
107107

108108

109-
Here's what you should do when the benchmark run was not sucessful. Let's assume the benchmark printed the following to the console:
109+
Here's what you should do when the benchmark run was not successful. Let's assume the benchmark printed the following to the console:
110110
```
111111
================================
112112
The following benchmarks failed:
113113
================================
114114
Executing frameworks/non-keyed/ef-js and benchmark 04_select1k failed: No paint event found
115-
run was not completely sucessful Benchmarking failed with errors
115+
run was not completely successful Benchmarking failed with errors
116116
```
117117
You'll now have to run the benchmark again for those that failed like that:
118118
```
File renamed without changes.

frameworks/keyed/angular-nozone/angular.json renamed to frameworks/keyed/angular-cf-nozone/angular.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,18 +68,18 @@
6868
"builder": "@angular-devkit/build-angular:dev-server",
6969
"configurations": {
7070
"production": {
71-
"browserTarget": "angular:build:production"
71+
"buildTarget": "angular:build:production"
7272
},
7373
"development": {
74-
"browserTarget": "angular:build:development"
74+
"buildTarget": "angular:build:development"
7575
}
7676
},
7777
"defaultConfiguration": "development"
7878
},
7979
"extract-i18n": {
8080
"builder": "@angular-devkit/build-angular:extract-i18n",
8181
"options": {
82-
"browserTarget": "angular:build"
82+
"buildTarget": "angular:build"
8383
}
8484
}
8585
}

0 commit comments

Comments
 (0)