Merge branch 'fix-karyon-dist' of https://github.com/nakrovati/js-framework-benchmark into nakrovati-fix-karyon-dist

krausest · krausest · commit 5338718fa525 · 2023-07-29T18:27:53.000Z
diff --git a/frameworks/keyed/karyon/index.html b/frameworks/keyed/karyon/index.html
@@ -4,7 +4,7 @@
         <meta charset="utf-8"/>
         <title>Karyon</title>
         <link href="/css/currentStyle.css" rel="stylesheet"/>
-        <script type="module" src="app.bundle.js"></script>
+        <script type="module" src="dist/app.js"></script>
     </head>
     <body></body>
 </html>
diff --git a/frameworks/keyed/karyon/package.json b/frameworks/keyed/karyon/package.json
@@ -13,6 +13,7 @@
     "esbuild": "0.18.10"
   },
   "scripts": {
-    "build-prod": "esbuild app.js --bundle --minify --outfile=app.bundle.js"
+    "build-dev":"esbuild src/app.js --outfile=dist/app.js --bundle --watch",
+    "build-prod": "esbuild src/app.js --outfile=dist/app.js --bundle --minify"
   }
 }
diff --git a/frameworks/keyed/karyon/src/app.js b/frameworks/keyed/karyon/src/app.js
diff --git a/zip.js b/zip.js
@@ -95,8 +95,6 @@ function addFrameworksToZip(keyedType, frameworkDir, frameworkName) {
       `${frameworkDir}/src/bundle.js`,
       `${zipFrameworkPath}/src`
     );
-  } else if (frameworkName === "karyon") {
-    addLocalFileIfExists(`${frameworkDir}/app.bundle.js`, zipFrameworkPath);
   } else {
     addLocalFolderIfExists(
       `${frameworkDir}/output`,

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@`
`13`	`13`	`"esbuild": "0.18.10"`
`14`	`14`	`},`
`15`	`15`	`"scripts": {`
`16`		`- "build-prod": "esbuild app.js --bundle --minify --outfile=app.bundle.js"`
	`16`	`+ "build-dev":"esbuild src/app.js --outfile=dist/app.js --bundle --watch",`
	`17`	`+ "build-prod": "esbuild src/app.js --outfile=dist/app.js --bundle --minify"`
`17`	`18`	`}`
`18`	`19`	`}`