Skip to content

Commit 5464846

Browse files
committed
refactor, style: use ant design for website styling
1 parent cf2e583 commit 5464846

27 files changed

+1250
-578
lines changed

webdriver-ts-results/package-lock.json

Lines changed: 940 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webdriver-ts-results/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
"private": true,
55
"type": "module",
66
"dependencies": {
7+
"@ant-design/icons": "^5.3.1",
8+
"antd": "^5.14.2",
79
"jstat": "^1.9.6",
810
"plotly.js-cartesian-dist": "2.18.2",
911
"react": "^18.2.0",

webdriver-ts-results/src/App.css

Lines changed: 8 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@
1111
body {
1212
font-family: Helvetica, Arial, sans-serif;
1313
font-size: 14px;
14-
margin: 10px;
14+
margin: 0;
15+
padding: 0.5rem;
1516
}
1617

1718
a,
@@ -20,22 +21,6 @@ a:hover {
2021
text-decoration: none;
2122
}
2223

23-
button,
24-
select {
25-
font-size: 14px;
26-
}
27-
28-
select {
29-
border: 1px solid var(--border-color);
30-
border-radius: 4px;
31-
height: 29px;
32-
background: white;
33-
}
34-
35-
input + label {
36-
margin-left: 5px;
37-
}
38-
3924
thead.dummy th {
4025
padding: 0;
4126
border: 0;
@@ -145,7 +130,8 @@ dl {
145130
padding: 0;
146131
margin-bottom: 16px;
147132
}
148-
dt {
133+
dt,
134+
.dt {
149135
float: left;
150136
width: 50px;
151137
padding: 0;
@@ -198,3 +184,7 @@ dd {
198184
.check-full-width::after {
199185
display: inline-block;
200186
}
187+
188+
.page-container {
189+
padding: 0.5rem;
190+
}

webdriver-ts-results/src/App.tsx

Lines changed: 24 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,25 @@ import "./App.css";
22
import { FrameworkType, knownIssues } from "./Common";
33
import ResultTable from "./components/ResultTable";
44
import SelectionBar from "./components/selection/SelectionBar";
5+
import { List, Typography } from "antd";
56

67
const KnownIssuesList = () => {
8+
const data = knownIssues;
9+
710
return (
8-
<section>
9-
<h3>Known issues and notes</h3>
10-
{knownIssues.map((issue) => (
11-
<dl key={issue.issue.toFixed()} id={issue.issue.toFixed()}>
12-
<dt>
13-
<a target="_blank" rel="noopener noreferrer" href={issue.link}>
14-
{issue.issue.toFixed()}
15-
</a>
16-
</dt>
17-
<dd>{issue.text}</dd>
18-
</dl>
19-
))}
20-
</section>
11+
<List
12+
header={<div>Known issues and notes</div>}
13+
bordered
14+
dataSource={data}
15+
renderItem={(issue) => (
16+
<List.Item>
17+
<Typography.Text className="dt">
18+
<a href={issue.link}>{issue.issue}</a>
19+
</Typography.Text>{" "}
20+
{issue.text}
21+
</List.Item>
22+
)}
23+
/>
2124
);
2225
};
2326

@@ -51,18 +54,21 @@ const App = () => {
5154
{disclaimer}
5255
{testEnvironmentInfo}
5356
<p>
54-
After chrome 119 official results we&apos;ve changed a detail for the benchmark:
55-
We now open a new tab for each benchmark iteration, earlier runs reused the tab per benchmark and implementation.
57+
After chrome 119 official results we&apos;ve changed a detail for the benchmark: We now open a new tab for each
58+
benchmark iteration, earlier runs reused the tab per benchmark and implementation.
5659
</p>
5760
<p>
58-
Starting with chrome 118 the benchmark uses a <a href="https://github.com/krausest/js-framework-benchmark/wiki/Computation-of-the-weighted-geometric-mean">weighted geometric mean </a> to compute the overall result.
61+
Starting with chrome 118 the benchmark uses a{" "}
62+
<a href="https://github.com/krausest/js-framework-benchmark/wiki/Computation-of-the-weighted-geometric-mean">
63+
weighted geometric mean{" "}
64+
</a>{" "}
65+
to compute the overall result.
5966
</p>
60-
6167
<main>
6268
<SelectionBar showDurationSelection={true} />
6369
<ResultTable type={FrameworkType.KEYED} />
6470
<ResultTable type={FrameworkType.NON_KEYED} />
65-
<KnownIssuesList></KnownIssuesList>
71+
<KnownIssuesList />
6672
</main>
6773
</>
6874
);

0 commit comments

Comments
 (0)