Skip to content

Commit 563f9a4

Browse files
committed
chore(web-ts-results): rename selectedFrameworksDropDown
1 parent e5144e5 commit 563f9a4

File tree

3 files changed

+13
-12
lines changed

3 files changed

+13
-12
lines changed

webdriver-ts-results/src/components/selection/CopyPasteSelection.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ const CopyPasteSelection = () => {
5252
const copy = () => {
5353
const serializedState = {
5454
frameworks: state.frameworks
55-
.filter((f) => state.selectedFrameworksDropDown.has(f))
55+
.filter((f) => state.selectedFrameworks.has(f))
5656
.map((f) => f.dir),
5757
benchmarks: state.benchmarks
5858
.filter((f) => state.selectedBenchmarks.has(f))

webdriver-ts-results/src/components/selection/FrameworkSelector/FrameworkSelectorCategory.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,7 @@ interface Props {
1212
const FrameworkSelectorCategory = ({ label, frameworkType }: Props) => {
1313
console.log("FrameworkSelectorCategory");
1414

15-
const selectedFrameworks = useRootStore(
16-
(state) => state.selectedFrameworksDropDown,
17-
);
15+
const selectedFrameworks = useRootStore((state) => state.selectedFrameworks);
1816
const frameworks = useRootStore(
1917
(state) => state.frameworkLists[frameworkType],
2018
);

webdriver-ts-results/src/reducer.ts

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ interface State {
8686
benchmarks: Array<Benchmark>;
8787
frameworks: Array<Framework>;
8888
selectedBenchmarks: Set<Benchmark>;
89-
selectedFrameworksDropDown: Set<Framework>;
89+
selectedFrameworks: Set<Framework>;
9090
resultTables: ResultTables;
9191
sortKey: string;
9292
displayMode: DisplayMode;
@@ -116,7 +116,7 @@ interface Actions {
116116
function updateResultTable({
117117
frameworks,
118118
benchmarks,
119-
selectedFrameworksDropDown: selectedFrameworks,
119+
selectedFrameworks: selectedFrameworks,
120120
selectedBenchmarks,
121121
sortKey,
122122
displayMode,
@@ -202,7 +202,7 @@ const preInitialState: State = {
202202
},
203203
// dynamic
204204
selectedBenchmarks: allBenchmarks,
205-
selectedFrameworksDropDown: allFrameworks,
205+
selectedFrameworks: allFrameworks,
206206
sortKey: SORT_BY_GEOMMEAN_CPU,
207207
displayMode: DisplayMode.DisplayMedian,
208208
resultTables: {
@@ -237,27 +237,30 @@ export const useRootStore = create<State & Actions>((set, get) => ({
237237
},
238238
areAllFrameworksSelected: (type) => {
239239
return get().frameworkLists[type].every((framework) =>
240-
get().selectedFrameworksDropDown.has(framework),
240+
get().selectedFrameworks.has(framework),
241241
);
242242
},
243243
isNoneFrameworkSelected: (type) => {
244244
return get().frameworkLists[type].every(
245-
(framework) => !get().selectedFrameworksDropDown.has(framework),
245+
(framework) => !get().selectedFrameworks.has(framework),
246246
);
247247
},
248248
// Actions
249249
selectFramework: (framework: Framework, add: boolean) => {
250-
const newSelectedFramework = new Set(get().selectedFrameworksDropDown);
250+
const newSelectedFramework = new Set(get().selectedFrameworks);
251251

252252
add
253253
? newSelectedFramework.add(framework)
254254
: newSelectedFramework.delete(framework);
255255

256256
const t = { ...get(), selectedFrameworksDropDown: newSelectedFramework };
257-
return set(() => ({ ...t, resultTables: updateResultTable(t) }));
257+
return set(() => ({
258+
...t,
259+
resultTables: updateResultTable(t),
260+
}));
258261
},
259262
selectAllFrameworks: (frameworkType: FrameworkType, add: boolean) => {
260-
const newSelectedFramework = new Set(get().selectedFrameworksDropDown);
263+
const newSelectedFramework = new Set(get().selectedFrameworks);
261264
const frameworks =
262265
frameworkType === FrameworkType.KEYED
263266
? get().frameworkLists[FrameworkType.KEYED]

0 commit comments

Comments
 (0)