Skip to content

Commit 5d16d90

Browse files
committed
Bump - performance improvements
1 parent de5dee5 commit 5d16d90

File tree

3 files changed

+13
-14
lines changed

3 files changed

+13
-14
lines changed

frameworks/keyed/michijs/package-lock.json

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

frameworks/keyed/michijs/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "js-framework-benchmark-michijs",
3-
"version": "2.0.3",
3+
"version": "2.0.4",
44
"description": "michijs",
55
"main": "index.js",
66
"js-framework-benchmark": {
@@ -34,6 +34,6 @@
3434
"typescript": "5.6.3"
3535
},
3636
"dependencies": {
37-
"@michijs/michijs": "2.0.3"
37+
"@michijs/michijs": "2.0.4"
3838
}
3939
}

frameworks/keyed/michijs/src/index.tsx

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,13 +67,14 @@ const adjectivesLength = adjectives.length;
6767
const coloursLength = colours.length;
6868
const nounsLength = nouns.length;
6969

70-
type Row = { label: string; id: number; selected?: string };
70+
type Row = { label: string; id: number; selected: string | undefined };
7171
let nextId = 1;
7272
let selectedItem: ObservableType<Row> | null = null;
7373
function buildData(count = 1000) {
7474
const data = new Array<Row>(count);
7575
for (let i = 0; i < count; i++)
7676
data[i] = {
77+
selected: undefined,
7778
id: nextId++,
7879
label: `${adjectives[_random(adjectivesLength)]} ${
7980
colours[_random(coloursLength)]
@@ -88,15 +89,13 @@ const add = () => rows.push(...buildData());
8889
const update = () => {
8990
for (let i = 0; i < rows.length; i += 10) {
9091
// Will be solved on https://github.com/microsoft/TypeScript/issues/43826
91-
// @ts-ignore
92-
rows[i].label += " !!!";
92+
const label = rows[i].label;
93+
label(`${label()} !!!`);
9394
}
9495
};
9596
const clear = () => rows.$clear();
9697
const select = (row: ObservableType<Row>) => {
97-
// Will be solved on https://github.com/microsoft/TypeScript/issues/43826
98-
// @ts-ignore
99-
row.selected = "danger";
98+
row.selected("danger");
10099
if (selectedItem) selectedItem.selected(undefined);
101100
selectedItem = row;
102101
};

0 commit comments

Comments
 (0)