Skip to content

Commit 6078dd5

Browse files
committed
Merge branch 'update_react-tagged-state_1.20.1' of https://github.com/oleggrishechkin/js-framework-benchmark into oleggrishechkin-update_react-tagged-state_1.20.1
2 parents 1aa4f96 + 917b8fb commit 6078dd5

File tree

3 files changed

+15
-30
lines changed

3 files changed

+15
-30
lines changed

frameworks/keyed/react-tagged-state/package-lock.json

Lines changed: 8 additions & 27 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

frameworks/keyed/react-tagged-state/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,6 @@
3333
"dependencies": {
3434
"react": "^18.1.0",
3535
"react-dom": "^18.1.0",
36-
"react-tagged-state": "^1.5.0"
36+
"react-tagged-state": "^1.20.2"
3737
}
3838
}

frameworks/keyed/react-tagged-state/src/main.jsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,12 @@ const data = createSignal([]);
3030

3131
let selected = createSignal(0);
3232

33+
const GlyphIcon = (
34+
<span className="glyphicon glyphicon-remove" aria-hidden="true"/>
35+
);
36+
3337
const Row = memo(({item}) => {
34-
const isSelected = useSelector(() => item.id === selected());
38+
const isSelected = useSelector(() => item.id === selected(), {pure: true});
3539
const handleSelect = useCallback(() => {
3640
selected(item.id);
3741
}, [item.id]);
@@ -46,7 +50,7 @@ const Row = memo(({item}) => {
4650
<a onClick={handleSelect}>{item.label}</a>
4751
</td>
4852
<td className="col-md-1">
49-
<a onClick={handleRemove}><span className="glyphicon glyphicon-remove" aria-hidden="true"/></a>
53+
<a onClick={handleRemove}>{GlyphIcon}</a>
5054
</td>
5155
<td className="col-md-6"/>
5256
</tr>

0 commit comments

Comments
 (0)