Skip to content

Commit 60fa0af

Browse files
committed
fix unflagged handling for benchmark selection
1 parent ceb4415 commit 60fa0af

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

webdriver-ts-results/src/components/SelectionToolbar/BenchmarkSelector/BenchmarkSelectorCategory.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { BenchmarkType } from "@/Common";
1+
import { BenchmarkType, FrameworkType } from "@/Common";
22
import { useRootStore } from "@/store";
33
import SelectorContentContainer from "@/components/SelectionToolbar/SelectorContentContainer";
44
import BenchmarkSelectorList from "./BenchmarkSelectorList";

webdriver-ts-results/src/components/SelectionToolbar/SelectorContentContainer/SelectionContentContainer.tsx

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@ import { Button, Flex } from "antd";
55
interface Props {
66
children: React.ReactElement;
77
selectNone: (event: React.SyntheticEvent) => void;
8-
selectUnflagged: (event: React.SyntheticEvent) => void;
8+
selectUnflagged?: (event: React.SyntheticEvent) => void;
99
selectAll: (event: React.SyntheticEvent) => void;
1010
isNoneSelected: boolean;
11-
isUnflaggedSelected: boolean;
11+
isUnflaggedSelected?: boolean;
1212
areAllSelected: boolean;
1313
grid?: boolean;
1414
label: string;
@@ -30,7 +30,7 @@ const SelectorContentContainer = ({
3030
};
3131

3232
const handleSelectUnflagged = (event: React.MouseEvent) => {
33-
!isUnflaggedSelected && selectUnflagged(event);
33+
!isUnflaggedSelected && selectUnflagged && selectUnflagged(event);
3434
};
3535

3636
const handleSelectAll = (event: React.MouseEvent) => {
@@ -48,9 +48,10 @@ const SelectorContentContainer = ({
4848
<Button type="text" onClick={handleSelectAll} disabled={areAllSelected} aria-label="Select all">
4949
All
5050
</Button>
51-
<Button type="text" onClick={handleSelectUnflagged} disabled={isUnflaggedSelected} aria-label="Select unflagged">
51+
{selectUnflagged &&
52+
(<Button type="text" onClick={handleSelectUnflagged} disabled={isUnflaggedSelected} aria-label="Select unflagged">
5253
Unflagged
53-
</Button>
54+
</Button>)}
5455
</div>
5556
</Flex>
5657
<div className={`selector-content-container__content ${grid ? "grid" : ""}`}>

0 commit comments

Comments
 (0)