fix: eslint errors

Author: nakrovati

cli/check-obsolete.js

@@ -62,7 +62,7 @@ function maybeObsolete(packageName) {
 
     const modifiedDate = new Date(timeData.modified);
     const isObsolete = modifiedDate < obsoleteDate;
-    const formattedDate = modifiedDate.toISOString().substring(0, 10);
+    const formattedDate = modifiedDate.toISOString().slice(0, 10);
 
     return { isObsolete, lastUpdate: formattedDate, packageName };
   } catch (error) {
@@ -96,7 +96,7 @@ export function checkObsoleteFrameworks({ debug }) {
       continue;
     }
 
-    const packageJSON = JSON.parse(fs.readFileSync(packageJSONPath, "utf-8"));
+    const packageJSON = JSON.parse(fs.readFileSync(packageJSONPath, "utf8"));
     const mainPackages = packageJSON?.["js-framework-benchmark"]?.frameworkVersionFromPackage;
 
     if (!mainPackages) {
@@ -109,7 +109,7 @@ export function checkObsoleteFrameworks({ debug }) {
     }
 
     const packages = mainPackages.split(":");
-    const isPackageObsolete = packages.map(maybeObsolete);
+    const isPackageObsolete = packages.map((element) => maybeObsolete(element));
 
     if (DEBUG) {
       console.log(`Results for ${type}/${name} ${isPackageObsolete}`);

cli/rebuild-all-frameworks.js

@@ -2,7 +2,7 @@
 import { execSync } from "node:child_process";
 import * as fs from "node:fs";
 import path from "node:path";
-import { takeWhile } from "./utils/common/index.js";
+import { takeWhile } from "./utils/index.js";
 import { getFrameworks } from "./helpers/frameworks.js";
 
 /*
@@ -27,7 +27,7 @@ npm run rebuild-frameworks --restartWith keyed/react
  */
 function shouldSkipFramework({ type, name }, restartWithFramework) {
   if (!restartWithFramework) return false;
-  if (restartWithFramework.indexOf("/") > -1) {
+  if (restartWithFramework.includes("/")) {
     return !`${type}/${name}`.startsWith(restartWithFramework);
   } else {
     return !name.startsWith(restartWithFramework);
@@ -39,7 +39,7 @@ function shouldSkipFramework({ type, name }, restartWithFramework) {
  * @param {string} command - The command to run
  * @param {string} [cwd] - The current working directory (optional)
  */
-function runCommand(command, cwd = undefined) {
+function runCommand(command, cwd) {
   console.log(command);
   execSync(command, { stdio: "inherit", cwd });
 }

cli/rebuild-build-single.js

@@ -21,12 +21,10 @@ Pass list of frameworks
  * @param {string} command - The command to run
  * @param {string|undefined} cwd - The current working directory (optional)
  */
-function runCommand(command, cwd = undefined) {
+function runCommand(command, cwd) {
   console.log(command);
-  if (cwd) {
-    if (!fs.existsSync(cwd)) {
-      throw `working directory ${cwd} doesn't exist.`;
-    }
+  if (cwd && !fs.existsSync(cwd)) {
+    throw `working directory ${cwd} doesn't exist.`;
   }
 
   execSync(command, { stdio: "inherit", cwd });

cli/rebuild-check-single.js

@@ -18,7 +18,7 @@ Pass list of frameworks
  * @param {string} command - The command to run
  * @param {string|undefined} cwd - The current working directory (optional)
  */
-function runCommand(command, cwd = undefined) {
+function runCommand(command, cwd) {
   console.log(command);
   execSync(command, { stdio: "inherit", cwd });
 }
@@ -42,7 +42,7 @@ export function rebuildCheckSingle({ frameworks }) {
     console.log("rebuild-check-single.js finished");
     console.log("All checks are fine!");
     console.log(`======> Please rerun the benchmark: npm run bench ${frameworkNames}`);
-  } catch (e) {
+  } catch (error) {
     console.log(`rebuild-check-single failed for ${frameworks.join(" ")}`);
     process.exit(-1);
   }

cli/rebuild-single-framework.js

@@ -33,7 +33,7 @@ export function rebuildSingleFramework({ frameworks, useCi }) {
     rebuildFrameworks(frameworks, useCi);
 
     rebuildCheckSingle({ frameworks });
-  } catch (e) {
+  } catch (error) {
     console.log(`ERROR: Rebuilding  ${frameworks} was not successful`);
   }
 }

cli/update-lockfiles.js

@@ -31,7 +31,7 @@ function runNpmInstall(frameworkPath) {
  */
 function getPackageLockJSONVersion(packageLockJSONPath) {
   try {
-    const packageLockJSON = fs.readFileSync(packageLockJSONPath, "utf-8");
+    const packageLockJSON = fs.readFileSync(packageLockJSONPath, "utf8");
     const parsedPackageLockJSON = JSON.parse(packageLockJSON);
     return parsedPackageLockJSON.lockfileVersion;
   } catch (error) {

cli/utils/common/index.js renamed to cli/utils/index.js

@@ -54,23 +54,33 @@ function addFrameworksToZip(frameworkType, frameworkDir, frameworkName) {
     addLocalFolderIfExists(`${frameworkDir}/public`, `${zipFrameworkPath}/public`);
   }
 
-  if (frameworkName === "halogen") {
-    addLocalFileIfExists(`${frameworkDir}/output/bundle.js`, `${zipFrameworkPath}/output`);
-  } else if (frameworkName === "dojo") {
-    addLocalFolderIfExists(`${frameworkDir}/output/dist`, `${zipFrameworkPath}/output/dist`);
-  } else if (frameworkName === "s2") {
-    addLocalFolderIfExists(
-      `${frameworkDir}/node_modules/s2-engine/dist`,
-      `${zipFrameworkPath}/node_modules/s2-engine/dist`
-    );
-  } else if (frameworkName === "stem") {
-    addLocalFolderIfExists(
-      `${frameworkDir}/node_modules/babel-polyfill/dist`,
-      `${zipFrameworkPath}/node_modules/babel-polyfill/dist`
-    );
-    addLocalFileIfExists(`${frameworkDir}/src/bundle.js`, `${zipFrameworkPath}/src`);
-  } else {
-    addLocalFolderIfExists(`${frameworkDir}/output`, `${zipFrameworkPath}/output`);
+  switch (frameworkName) {
+    case "halogen": {
+      addLocalFileIfExists(`${frameworkDir}/output/bundle.js`, `${zipFrameworkPath}/output`);
+      break;
+    }
+    case "dojo": {
+      addLocalFolderIfExists(`${frameworkDir}/output/dist`, `${zipFrameworkPath}/output/dist`);
+      break;
+    }
+    case "s2": {
+      addLocalFolderIfExists(
+        `${frameworkDir}/node_modules/s2-engine/dist`,
+        `${zipFrameworkPath}/node_modules/s2-engine/dist`
+      );
+      break;
+    }
+    case "stem": {
+      addLocalFolderIfExists(
+        `${frameworkDir}/node_modules/babel-polyfill/dist`,
+        `${zipFrameworkPath}/node_modules/babel-polyfill/dist`
+      );
+      addLocalFileIfExists(`${frameworkDir}/src/bundle.js`, `${zipFrameworkPath}/src`);
+      break;
+    }
+    default: {
+      addLocalFolderIfExists(`${frameworkDir}/output`, `${zipFrameworkPath}/output`);
+    }
   }
 }
 
@@ -83,7 +93,7 @@ export function createFrameworkZipArchive() {
 
     for (const frameworkName of frameworkNames) {
       const frameworkPath = path.resolve(frameworkTypeDirPath, frameworkName);
-      console.log("zipping ", frameworkPath);
+      console.log("zipping", frameworkPath);
 
       addFrameworksToZip(frameworkType, frameworkPath, frameworkName);
     }