Skip to content

Commit 6c45fe5

Browse files
authored
Merge pull request #1 from IgnaceMaes/use-plain-function-helper
2 parents 1f3e5f8 + a81cb8d commit 6c45fe5

File tree

3 files changed

+6
-51
lines changed

3 files changed

+6
-51
lines changed

frameworks/keyed/ember/app/components/my-table.gjs

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,30 +6,22 @@ import { on } from '@ember/modifier';
66
import { fn } from '@ember/helper';
77

88
import BsButton from 'ember-temp/components/bs-button';
9-
import eq from 'ember-temp/helpers/eq';
109
import {
1110
run, runLots, add, update, swapRows, deleteRow,
1211
} from 'ember-temp/utils/benchmark-helpers';
1312

13+
function eq(a, b) {
14+
return a === b;
15+
}
16+
1417
export default class MyTable extends Component {
1518
@tracked
1619
id = 1;
1720

1821
@tracked
1922
data = [];
2023

21-
@tracked
22-
_selected = undefined;
23-
24-
@service('state') state;
25-
26-
get selected() {
27-
return this._selected;
28-
}
29-
set selected(value) {
30-
this.state.updateSelection(value);
31-
this._selected = value;
32-
}
24+
@tracked selected = undefined;
3325

3426
@action create() {
3527
const result = run(this.id);
@@ -122,7 +114,7 @@ export default class MyTable extends Component {
122114
<table class="table table-hover table-striped test-data">
123115
<tbody>
124116
{{#each this.data key="id" as |item|}}
125-
<tr class={{if (eq item) 'danger'}}>
117+
<tr class={{if (eq item.id this.selected) 'danger'}}>
126118
<td class="col-md-1">{{item.id}}</td>
127119
<td class="col-md-4"><a {{on 'click' (fn this.select item)}}>{{item.label}}</a></td>
128120
<td class="col-md-1"><a {{on 'click' (fn this.remove item)}}><span class="glyphicon glyphicon-remove" aria-hidden="true"></span></a></td>

frameworks/keyed/ember/app/helpers/eq.js

Lines changed: 0 additions & 18 deletions
This file was deleted.

frameworks/keyed/ember/app/services/state.js

Lines changed: 0 additions & 19 deletions
This file was deleted.

0 commit comments

Comments
 (0)