Skip to content

Commit 7cdc2c6

Browse files
committed
improve handling of missing values
1 parent 14e1c11 commit 7cdc2c6

File tree

2 files changed

+24
-15
lines changed

2 files changed

+24
-15
lines changed

webdriver-ts-results/src/reducer.ts

Lines changed: 21 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -39,20 +39,29 @@ const results: Result[] = rawResults.map((result) => {
3939
values[key] = vals;
4040
}
4141
if (result.v[CpuDurationMode.Total] && result.v[CpuDurationMode.Script] && result.v[CpuDurationMode.Render]) {
42-
if (result.v[CpuDurationMode.Total].length !== result.v[CpuDurationMode.Script].length)
43-
throw "Lengths must match";
44-
let r = [];
45-
for (let i = 0; i < result.v[CpuDurationMode.Total].length; i++) {
46-
r.push(result.v[CpuDurationMode.Total][i] - result.v[CpuDurationMode.Script][i]);
42+
if (result.v[CpuDurationMode.Total].length !== result.v[CpuDurationMode.Script].length) {
43+
const vals = {
44+
mean: NaN,
45+
median: NaN,
46+
standardDeviation: NaN,
47+
values: [NaN],
48+
};
49+
debugger;
50+
values[CpuDurationMode.BrowserOnly] = vals;
51+
} else {
52+
let r = [];
53+
for (let i = 0; i < result.v[CpuDurationMode.Total].length; i++) {
54+
r.push(result.v[CpuDurationMode.Total][i] - result.v[CpuDurationMode.Script][i]);
55+
}
56+
const vals = {
57+
mean: jStat.mean(r),
58+
median: jStat.median(r),
59+
standardDeviation: jStat.stdev(r, true),
60+
values: r,
61+
};
62+
values[CpuDurationMode.BrowserOnly] = vals;
4763
}
48-
const vals = {
49-
mean: jStat.mean(r),
50-
median: jStat.median(r),
51-
standardDeviation: jStat.stdev(r, true),
52-
values: r,
53-
};
5464
// if (result.f==='miso-v1.4.0-keyed' || result.f==='vanillajs-keyed') debugger;
55-
values[CpuDurationMode.BrowserOnly] = vals;
5665
}
5766

5867
return { framework: result.f, benchmark: result.b, results: values };

webdriver-ts-results/src/results.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2461,9 +2461,9 @@ export const results: RawResult[]=[
24612461
{"f":"valtio-v18.2.0 + 1.10.3-keyed","b":"34_startup-totalbytes","v":{"DEFAULT":[284.9931640625]}},
24622462
{"f":"valtio-v18.2.0 + 1.10.3-keyed","b":"41_size-uncompressed","v":{"DEFAULT":[146.716796875]}},
24632463
{"f":"valtio-v18.2.0 + 1.10.3-keyed","b":"42_size-compressed","v":{"DEFAULT":[41.5693359375]}},
2464-
{"f":"vanillajs-keyed","b":"01_run1k","v":{"total":[38.188,38.169,39.446,39.939,39.48,38.591,39.837,38.776,37.731,39.305,41.55,38.281,41.255,39.73,38.431],"script":[2.122,2.038,2.081,2.257,2.052,2.203,2.096,2.08,2.054,2.215,2.186,2.023,2.061,2.145,2.089],"paint":[35.63,35.678,36.867,37.212,36.992,35.968,37.304,36.211,35.202,36.612,38.853,35.823,38.754,37.113,35.869]}},
2465-
{"f":"vanillajs-keyed","b":"02_replace1k","v":{"total":[37.318,39.173,39.611,39.819,38.093,39.53,39.167,37.888,37.25,39.845,38.169,37.221,37.849,40.121,37.773],"script":[4.561,4.608,4.574,4.814,4.63,4.74,4.711,4.593,4.563,4.484,4.584,4.487,4.533,4.638,4.554],"paint":[32.341,34.105,34.26,34.297,33.016,34.352,34.037,32.855,32.196,34.897,33.134,32.331,32.845,34.793,32.805]}},
2466-
{"f":"vanillajs-keyed","b":"03_update10th1k_x16","v":{"total":[18.131,18.042,17.704,18.107,18.742,18.425,17.579,18.533,17.532,17.627,17.803,19.616,18.09,18.384,18.024],"script":[0.989,0.54,0.84,1.121,1.153,0.9,0.177,0.721,1.158,0.174,0.914,1.099,0.634,0.787,0.175],"paint":[16.13,15.265,15.266,14.743,16.567,15.386,16.061,16.641,14.687,16.067,15.496,16.796,15.651,15.469,15.638]}},
2464+
{"f":"vanillajs-keyed","b":"01_run1k","v":{"total":[39.254,39.467,40.237,39.333,40.802,38.593,39.695,39.8,38.282,38.527,40.13,38.307,39.195,38.179,37.802],"script":[1.969,2.117,2.169,2.183,2.027,2.025,2.039,2.131,2.072,2.026,2.081,2.02,2.074,2.125,2.081],"paint":[36.793,36.875,37.403,36.712,38.051,36.126,37.179,37.161,35.739,36.043,37.525,35.842,36.414,35.524,35.27]}},
2465+
{"f":"vanillajs-keyed","b":"02_replace1k","v":{"total":[38.91,38.604,37.983,37.226,39.814,38.549,39.43,38.926,40.947,39.496,40.952,39.877,37.801,38.795,39.993],"script":[4.58,4.469,4.545,4.676,4.423,4.536,4.502,4.458,4.409,4.649,4.701,4.633,4.607,4.754,4.69],"paint":[33.854,33.656,33.022,32.168,34.721,33.553,34.465,33.743,36.082,34.407,35.858,34.614,32.819,33.634,34.907]}},
2466+
{"f":"vanillajs-keyed","b":"03_update10th1k_x16","v":{"total":[21.361,19.581,18.882,20.039,19.182,18.859,20.527,18.673,18.556,18.618,18.09,18.958,18.947,18.124,19.009],"script":[1.345,1.201,0.787,0.999,0.987,0.991,0.748,0.974,0.828,0.179,0.968,0.985,0.703,0.524,0.775],"paint":[18.182,16.546,16.525,17.574,16.924,16.905,18.196,16.443,16.753,17.217,15.489,16.462,16.148,15.502,16.254]}},
24672467
{"f":"vanillajs-keyed","b":"04_select1k","v":{"total":[3.492,2.814,2.769,2.729,3.73,2.203,4.644,3.521,3.118,2.771,3.39,2.917,3.633,2.89,3.015,2.033,2.667,4.264,2.586,3.237,3.009,3.133,2.879,3.425,4.232],"script":[0.642,0.056,0.304,0.056,0.051,0.055,0.055,0.046,0.705,0.058,0.05,0.053,1.079,0.065,0.051,0.059,0.055,0.071,0.058,0.057,0.06,0.056,0.077,0.061,0.051],"paint":[2.257,1.934,1.526,1.693,3.53,1.624,3.276,2.282,2.286,1.517,2.576,1.814,1.686,2.706,2.457,1.873,1.398,3.627,1.617,2.615,1.727,2.971,1.673,2.173,3.084]}},
24682468
{"f":"vanillajs-keyed","b":"05_swap1k","v":{"total":[20.699,21.191,22.066,22.358,21.376,21.455,22.619,21.244,21.644,21.644,21.909,22.239,22.829,21.968,20.941],"script":[0.451,0.075,0.663,0.085,0.939,0.228,0.886,0.078,0.081,0.078,0.082,0.997,0.078,0.726,0.09],"paint":[18.648,19.711,18.948,20.624,18.738,19.035,20.642,18.868,19.385,20.038,19.999,19.39,20.326,18.78,19.472]}},
24692469
{"f":"vanillajs-keyed","b":"06_remove-one-1k","v":{"total":[16.545,16.643,16.707,16.957,17.908,16.839,16.989,16.187,16.982,16.853,17.312,17.036,16.957,17.962,17.124],"script":[0.09,0.139,0.12,0.455,0.101,0.36,0.376,0.133,0.124,0.246,0.131,0.117,0.281,0.46,0.131],"paint":[15.697,15.666,15.706,15.462,16.521,15.424,15.711,15.253,15.735,15.683,15.95,15.979,15.384,16.191,16.207]}},

0 commit comments

Comments
 (0)