refactor: initialize frameworksDirectory path

Author: nakrovati

server/config/directories.js

@@ -1,11 +1,14 @@
-import path from "path";
-import { cwd } from "process";
+import { join } from "path";
+import process from "process";
 
-let FrameworksDirectory = path.join(cwd(), "..", "frameworks");
+const isFrameworksDirectorySpecifies = process.argv.length === 3;
 
-if (process.argv.length === 3) {
+const frameworksDirectory = isFrameworksDirectorySpecifies
+  ? join(process.cwd(), "..", process.argv[2])
+  : join(process.cwd(), "..", "frameworks");
+
+if (isFrameworksDirectorySpecifies) {
   console.log(`Changing working directory to ${process.argv[2]}`);
-  FrameworksDirectory = path.join(cwd(), "..", process.argv[2]);
 }
 
-export { FrameworksDirectory };
+export { frameworksDirectory };

server/frameworks/frameworksControllers.js

@@ -1,13 +1,13 @@
 import path from "path";
 import fs from "fs";
 
-import { FrameworksDirectory } from "../config/directories.js";
+import { frameworksDirectory } from "../config/directories.js";
 import isFrameworkDir from "./utils/isFrameworkDir.js";
 import { loadFrameworkInfo } from "./helpers/index.js";
 
 export async function loadFrameworkVersionInformation(filterForFramework) {
   const resultsProm = [];
-  const frameworksPath = path.resolve(FrameworksDirectory);
+  const frameworksPath = path.resolve(frameworksDirectory);
   const keyedTypes = ["keyed", "non-keyed"];
 
   for (const keyedType of keyedTypes) {

server/frameworks/helpers/index.js

@@ -2,7 +2,7 @@ import fs from "fs";
 import fsp from "fs/promises";
 import path from "path";
 
-import { FrameworksDirectory } from "../../config/directories.js";
+import { frameworksDirectory } from "../../config/directories.js";
 
 function copyProps(result, benchmarkData) {
   const {
@@ -35,7 +35,7 @@ export async function loadFrameworkInfo(keyedDir, directoryName) {
   };
 
   const frameworkPath = path.resolve(
-    FrameworksDirectory,
+    frameworksDirectory,
     keyedDir,
     directoryName
   );

server/frameworks/utils/isFrameworkDir.js

@@ -1,6 +1,6 @@
 import fs from "fs";
 import path from "path";
-import { FrameworksDirectory } from "../../config/directories.js";
+import { frameworksDirectory } from "../../config/directories.js";
 
 /**
  * @param {string} keyedDir
@@ -9,7 +9,7 @@ import { FrameworksDirectory } from "../../config/directories.js";
  */
 function isFrameworkDir(keyedDir, directoryName) {
   const frameworkPath = path.resolve(
-    FrameworksDirectory,
+    frameworksDirectory,
     keyedDir,
     directoryName
   );

server/index.js

@@ -6,7 +6,7 @@ import { addSiteIsolationForIndex } from "./middlewares/addSiteIsolationForIndex
 import frameworksRouter from "./frameworks/frameworksRouter.js";
 import cspRouter from "./csp/cspRouter.js";
 import { isCSPEnabled } from "./csp/cspControllers.js";
-import { FrameworksDirectory } from "./config/directories.js";
+import { frameworksDirectory } from "./config/directories.js";
 
 const app = express();
 const PORT = 8080;
@@ -18,7 +18,7 @@ app.use(addSiteIsolationForIndex);
 
 app.use(
   "/frameworks",
-  express.static(FrameworksDirectory, {
+  express.static(frameworksDirectory, {
     setHeaders: (res, path) => {
       if (isCSPEnabled && path.endsWith("index.html")) {
         console.log("adding CSP to ", path);
@@ -31,7 +31,7 @@ app.use(
   })
 );
 app.use("/webdriver-ts-results", express.static(webDriverResultDirectory));
-app.use("/css", express.static(path.join(FrameworksDirectory, "..", "css")));
+app.use("/css", express.static(path.join(frameworksDirectory, "..", "css")));
 
 app.use(frameworksRouter);
 app.use(cspRouter);