Skip to content

Commit 977d5d1

Browse files
committed
Merge branch 'openUI5' of https://github.com/albertlast/js-framework-benchmark into albertlast-openUI5
2 parents 491c3cf + ab0f02b commit 977d5d1

29 files changed

+12
-10
lines changed

frameworks/keyed/openui5/package.json renamed to frameworks/non-keyed/openui5/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"version": "1.0.0",
44
"description": "UI5 Benchmark",
55
"js-framework-benchmark": {
6-
"frameworkVersionFromPackage": "openui5",
6+
"frameworkVersion": "1.119.1",
77
"frameworkHomeURL": "https://openui5.org/"
88
},
99
"scripts": {

frameworks/keyed/openui5/webapp/element/MyColumnListItemRenderer.js renamed to frameworks/non-keyed/openui5/webapp/element/MyColumnListItemRenderer.js

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,7 @@ sap.ui.define(
5858
}
5959
};
6060

61-
MyColumnListItemRenderer.makeFocusable = function (rm) {
62-
if (Device.system.desktop) {
63-
rm.attr("tabindex", "-1");
64-
rm.class("sapMTblCellFocusable");
65-
}
66-
};
61+
MyColumnListItemRenderer.makeFocusable = function (rm) {};
6762

6863
MyColumnListItemRenderer.openStartGridCell = function (
6964
rm,
@@ -72,10 +67,17 @@ sap.ui.define(
7267
sId,
7368
sClass
7469
) {
70+
const benchmarkClass = {
71+
1: "col-md-1",
72+
2: "col-md-4",
73+
3: "col-md-1",
74+
4: "col-md-6",
75+
};
76+
const aria = oLI.aAriaOwns.push(sId);
7577
rm.openStart(sTag, sId);
76-
rm.class(sClass);
78+
rm.class(benchmarkClass[aria]);
7779
rm.attr("role", "gridcell");
78-
rm.attr("aria-colindex", oLI.aAriaOwns.push(sId));
80+
rm.attr("aria-colindex", aria);
7981
this.makeFocusable(rm);
8082
if (oLI.isSelectable()) {
8183
rm.attr("aria-selected", oLI.getSelected());
@@ -190,7 +192,7 @@ sap.ui.define(
190192
vAlign = oColumn.getVAlign(),
191193
bRenderCell = true;
192194

193-
this.openStartGridCell(rm, oLI, "td", sCellId, "sapMListTblCell");
195+
this.openStartGridCell(rm, oLI, "td", sCellId, "");
194196
rm.attr("data-sap-ui-column", oColumn.getId());
195197
rm.style("text-align", oColumn.getCssAlign());
196198
aStyleClass.forEach(function (sClassName) {

0 commit comments

Comments
 (0)